Skip to content

Commit 7751c07

Browse files
authored
Merge pull request #7296 from continuedev/nate/more-warnings-fixes
Nate/more-warnings-fixes
2 parents ec35f0d + 785ad32 commit 7751c07

File tree

19 files changed

+3317
-3544
lines changed

19 files changed

+3317
-3544
lines changed

.github/actions/run-jetbrains-tests/action.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,13 @@ runs:
9393
path: binary/node_modules
9494
key: ${{ runner.os }}-binary-node-modules-${{ hashFiles('binary/package-lock.json') }}
9595

96+
- name: Install binary dependencies
97+
if: steps.binary-cache.outputs.cache-hit != 'true'
98+
shell: bash
99+
run: |
100+
cd binary
101+
npm ci
102+
96103
- name: Build the binaries
97104
shell: bash
98105
run: |

.github/workflows/cli-pr-checks.yml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
- name: Install dependencies
3737
run: |
3838
cd extensions/cli
39-
npm ci
39+
npm ci --include=optional
4040
4141
- name: Run linting
4242
run: |
@@ -58,8 +58,14 @@ jobs:
5858
uses: actions/setup-node@v4
5959
with:
6060
node-version: ${{ matrix.node-version }}
61-
cache: "npm"
62-
cache-dependency-path: extensions/cli/package-lock.json
61+
62+
- name: Cache CLI node_modules
63+
uses: actions/cache@v4
64+
with:
65+
path: extensions/cli/node_modules
66+
key: ${{ runner.os }}-node${{ matrix.node-version }}-cli-modules-${{ hashFiles('extensions/cli/package-lock.json') }}
67+
restore-keys: |
68+
${{ runner.os }}-node${{ matrix.node-version }}-cli-modules-
6369
6470
- name: Setup packages
6571
uses: ./.github/actions/setup-packages
@@ -72,13 +78,18 @@ jobs:
7278
- name: Install dependencies
7379
run: |
7480
cd extensions/cli
75-
npm ci
81+
npm ci --include=optional
7682
7783
- name: Build
7884
run: |
7985
cd extensions/cli
8086
npm run build
8187
88+
- name: Run smoke tests
89+
run: |
90+
cd extensions/cli
91+
npm run test:smoke
92+
8293
# e2e tests are failing on Windows specifically - likely due to stdout flush issues
8394
- name: Run tests
8495
if: matrix.os != 'windows-latest'

0 commit comments

Comments
 (0)