Skip to content

Commit b72b261

Browse files
fix: remove keepAliveMsecs from fetch agent (#8378)
* fix: remove `keepAliveMsecs` from fetch agent * fix tests
1 parent abe5d49 commit b72b261

File tree

6 files changed

+5
-16
lines changed

6 files changed

+5
-16
lines changed

binary/package-lock.json

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/package-lock.json

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extensions/vscode/package-lock.json

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gui/package-lock.json

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/fetch/src/getAgentOptions.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ test("getAgentOptions returns basic configuration with default values", async ()
5050
// Check default timeout (7200 seconds = 2 hours = 7,200,000 ms)
5151
expect(options.timeout).toBe(7200000);
5252
expect(options.sessionTimeout).toBe(7200000);
53-
expect(options.keepAliveMsecs).toBe(7200000);
5453
expect(options.keepAlive).toBe(true);
5554

5655
// Verify certificates array exists and contains items
@@ -71,7 +70,6 @@ test("getAgentOptions respects custom timeout", async () => {
7170
// Check timeout values (300 seconds = 300,000 ms)
7271
expect(options.timeout).toBe(300000);
7372
expect(options.sessionTimeout).toBe(300000);
74-
expect(options.keepAliveMsecs).toBe(300000);
7573
});
7674

7775
test("getAgentOptions uses verifySsl setting", async () => {

packages/fetch/src/getAgentOptions.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ export async function getAgentOptions(
2121
timeout,
2222
sessionTimeout: timeout,
2323
keepAlive: true,
24-
keepAliveMsecs: timeout,
2524
};
2625

2726
// Handle ClientCertificateOptions
@@ -38,9 +37,6 @@ export async function getAgentOptions(
3837

3938
if (process.env.VERBOSE_FETCH) {
4039
console.log(`Fetch agent options:`);
41-
console.log(
42-
`\tTimeout (sessionTimeout/keepAliveMsecs): ${agentOptions.timeout}`,
43-
);
4440
console.log(`\tTotal CA certs: ${ca.length}`);
4541
console.log(`\tGlobal/Root CA certs: ${certsCache.fixedCa.length}`);
4642
console.log(`\tCustom CA certs: ${ca.length - certsCache.fixedCa.length}`);

0 commit comments

Comments
 (0)