feat: ✨ Implement Claude memory tool #8269
Draft
+2,341
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 issues found across 18 files
Prompt for AI agents (all 4 issues)
Understand the root cause of the following 4 issues and fix them.
<file name="extensions/cli/src/tools/memory.ts">
<violation number="1" location="extensions/cli/src/tools/memory.ts:130">
Creating a memory file in a new directory always fails: after creating the missing parent directory we throw `Path not found`, so fs.writeFile never runs. Drop the throw so the command can proceed.</violation>
</file>
<file name="core/tools/implementations/memory.ts">
<violation number="1" location="core/tools/implementations/memory.ts:121">
Core memory command handling logic duplicates extensions/cli/src/tools/memory.ts:executeMemoryCommand() and its handlers</violation>
<violation number="2" location="core/tools/implementations/memory.ts:131">
After creating a missing directory, this branch still throws `Path not found`, so the create command always fails for new paths.</violation>
</file>
<file name="extensions/cli/src/tools/index.tsx">
<violation number="1" location="extensions/cli/src/tools/index.tsx:141">
This enables the memory tool for any model containing “claude”, but the feature must be restricted to the specific allowlisted models from the PR description.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| const fullPath = validatePath(args.path, memoryRoot); | ||
|
|
||
| if (!(await exists(fullPath))) { | ||
| throw new Error(`Path not found: ${args.path}`); |
There was a problem hiding this comment.
Creating a memory file in a new directory always fails: after creating the missing parent directory we throw Path not found, so fs.writeFile never runs. Drop the throw so the command can proceed.
Prompt for AI agents
Address the following comment on extensions/cli/src/tools/memory.ts at line 130:
<comment>Creating a memory file in a new directory always fails: after creating the missing parent directory we throw `Path not found`, so fs.writeFile never runs. Drop the throw so the command can proceed.</comment>
<file context>
@@ -0,0 +1,416 @@
+ const fullPath = validatePath(args.path, memoryRoot);
+
+ if (!(await exists(fullPath))) {
+ throw new Error(`Path not found: ${args.path}`);
+ }
+
</file context>
| const fullPath = validateMemoryPath(pathArg, memoryRoot); | ||
|
|
||
| if (!(await exists(fullPath))) { | ||
| throw new Error(`Path not found: ${pathArg}`); |
There was a problem hiding this comment.
After creating a missing directory, this branch still throws Path not found, so the create command always fails for new paths.
Prompt for AI agents
Address the following comment on core/tools/implementations/memory.ts at line 131:
<comment>After creating a missing directory, this branch still throws `Path not found`, so the create command always fails for new paths.</comment>
<file context>
@@ -0,0 +1,342 @@
+ const fullPath = validateMemoryPath(pathArg, memoryRoot);
+
+ if (!(await exists(fullPath))) {
+ throw new Error(`Path not found: ${pathArg}`);
+ }
+
</file context>
| }); | ||
| } | ||
|
|
||
| return isClaudeModel; |
There was a problem hiding this comment.
This enables the memory tool for any model containing “claude”, but the feature must be restricted to the specific allowlisted models from the PR description.
Prompt for AI agents
Address the following comment on extensions/cli/src/tools/index.tsx at line 141:
<comment>This enables the memory tool for any model containing “claude”, but the feature must be restricted to the specific allowlisted models from the PR description.</comment>
<file context>
@@ -106,10 +111,56 @@ function shouldExcludeEditTool(): boolean {
+ });
+ }
+
+ return isClaudeModel;
+ }
+ } catch (error) {
</file context>
| return [start, end]; | ||
| } | ||
|
|
||
| export const memoryToolImpl: ToolImpl = async (args, extras) => { |
There was a problem hiding this comment.
Core memory command handling logic duplicates extensions/cli/src/tools/memory.ts:executeMemoryCommand() and its handlers
Prompt for AI agents
Address the following comment on core/tools/implementations/memory.ts at line 121:
<comment>Core memory command handling logic duplicates extensions/cli/src/tools/memory.ts:executeMemoryCommand() and its handlers</comment>
<file context>
@@ -0,0 +1,342 @@
+ return [start, end];
+}
+
+export const memoryToolImpl: ToolImpl = async (args, extras) => {
+ const command = getStringArg(args, "command") as MemoryCommand;
+ const memoryRoot = await ensureMemoryRoot(extras);
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tool is only enabled for the following models:
AI Code Review
@continue-general-reviewor@continue-detailed-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
Added tests as needed.