🪪 Do not add doi to deposit if it cannot be normalized (#19)

Author: fwkoch

.changeset/fair-hotels-juggle.md

@@ -0,0 +1,5 @@
+---
+"crossref-utils": patch
+---
+
+Do not add doi to deposit if it cannot be normalized

src/cli/deposit.ts

@@ -41,6 +41,7 @@ import { curvenoteDoiData } from '../utils.js';
 import { conferencePaperFromMyst, conferenceXml } from '../conference.js';
 import { contributorsXmlFromMystEditors } from '../contributors.js';
 import { databaseXml, datasetFromMyst } from '../dataset.js';
+import { normalize } from 'doi-utils';
 
 type DepositType = 'conference' | 'journal' | 'preprint' | 'dataset';
 
@@ -93,7 +94,7 @@ export async function depositArticleFromSource(session: ISession, depositSource:
     }
     fileContents.forEach(({ references }) => {
       references.cite?.order.forEach((key) => {
-        const value = references.cite?.data[key].doi;
+        const value = normalize(references.cite?.data[key].doi);
         if (value) dois[key] = value;
         else session.log.warn(`Citation without DOI excluded from crossref deposit: ${key}`);
       });

src/conference.ts

@@ -2,7 +2,6 @@ import type { Element } from 'xast';
 import { e } from './utils.js';
 import type { ConferenceOptions, ConferencePaper } from './types.js';
 import type { PageFrontmatter } from 'myst-frontmatter';
-import { normalize } from 'doi-utils';
 import { contributorsXmlFromMystAuthors } from './contributors.js';
 import { publicationDateXml } from './dates.js';
 
@@ -84,7 +83,7 @@ export function conferencePaperXml({
       e(
         'citation_list',
         Object.entries(citations).map(([key, value]) => {
-          return e('citation', { key }, [e('doi', normalize(value))]);
+          return e('citation', { key }, [e('doi', value)]);
         }),
       ),
     );

src/dataset.ts

@@ -2,7 +2,6 @@ import type { Element } from 'xast';
 import { curvenoteDoiData, e } from './utils.js';
 import type { DatabaseOptions, DatasetMetadata, Titles } from './types.js';
 import type { PageFrontmatter } from 'myst-frontmatter';
-import { normalize } from 'doi-utils';
 import { contributorsXmlFromMystAuthors } from './contributors.js';
 import { dateXml } from './dates.js';
 
@@ -100,7 +99,7 @@ export function datasetXml({
       e(
         'citation_list',
         Object.entries(citations).map(([key, value]) => {
-          return e('citation', { key }, [e('doi', normalize(value))]);
+          return e('citation', { key }, [e('doi', value)]);
         }),
       ),
     );

src/journal.ts

@@ -217,7 +217,7 @@ export function journalArticleXml({
       e(
         'citation_list',
         Object.entries(citations).map(([key, value]) => {
-          return e('citation', { key }, [e('doi', normalize(value))]);
+          return e('citation', { key }, [e('doi', value)]);
         }),
       ),
     );

src/preprint.ts

@@ -83,7 +83,7 @@ export function preprintXml({
       e(
         'citation_list',
         Object.entries(citations).map(([key, value]) => {
-          return e('citation', { key }, [e('doi', normalize(value))]);
+          return e('citation', { key }, [e('doi', value)]);
         }),
       ),
     );