Merge pull request #1 from continuousphp/hotfix/status-type

Frédéric Dewinne · web-flow · commit 56ec0e1a847f · 2017-03-03T21:55:17.000+01:00
fix status mistyped according API documentation
diff --git a/src/Entity/StatusTrait.php b/src/Entity/StatusTrait.php
@@ -14,16 +14,16 @@
 trait StatusTrait
 {
     /**
-     * Status of the item. It can either be active or inactive.
+     * Status of the item.
      *
-     * @var boolean
+     * @var string
      */
     protected $status;
 
     /**
      * Get the status
      *
-     * @return boolean
+     * @return string
      */
     public function getStatus()
     {
@@ -33,12 +33,12 @@ public function getStatus()
     /**
      * Set the status
      *
-     * @param boolean $status
+     * @param string $status
      * @return StatusTrait
      */
     public function setStatus($status)
     {
-        $this->status = (bool)$status;
+        $this->status = $status;
         return $this;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -14,16 +14,16 @@`
`14`	`14`	`trait StatusTrait`
`15`	`15`	`{`
`16`	`16`	`/**`
`17`		`- * Status of the item. It can either be active or inactive.`
	`17`	`+ * Status of the item.`
`18`	`18`	`*`
`19`		`- * @var boolean`
	`19`	`+ * @var string`
`20`	`20`	`*/`
`21`	`21`	`protected $status;`
`22`	`22`
`23`	`23`	`/**`
`24`	`24`	`* Get the status`
`25`	`25`	`*`
`26`		`- * @return boolean`
	`26`	`+ * @return string`
`27`	`27`	`*/`
`28`	`28`	`public function getStatus()`
`29`	`29`	`{`
`@@ -33,12 +33,12 @@ public function getStatus()`
`33`	`33`	`/**`
`34`	`34`	`* Set the status`
`35`	`35`	`*`
`36`		`- * @param boolean $status`
	`36`	`+ * @param string $status`
`37`	`37`	`* @return StatusTrait`
`38`	`38`	`*/`
`39`	`39`	`public function setStatus($status)`
`40`	`40`	`{`
`41`		`- $this->status = (bool)$status;`
	`41`	`+ $this->status = $status;`
`42`	`42`	`return $this;`
`43`	`43`	`}`
`44`	`44`