Skip to content

Commit 251e9b0

Browse files
Address code review feedback
- helper.cpp: Reduce numpad digit case repetition using fall-through with arithmetic mapping (per @Yaraslaut) Signed-off-by: Christian Parpart <christian@parpart.family>
1 parent 8d25202 commit 251e9b0

File tree

1 file changed

+1
-28
lines changed

1 file changed

+1
-28
lines changed

src/contour/helper.cpp

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -454,43 +454,16 @@ bool sendKeyEvent(QKeyEvent* event, vtbackend::KeyboardEventType eventType, Term
454454
// When NumLock is OFF, Qt reports navigation keys instead (Insert, End, etc.).
455455
// So the presence of these key codes definitionally implies NumLock is active.
456456
case Qt::Key_0:
457-
mappedKey = Key::Numpad_0;
458-
inferredModifiers |= Modifier::NumLock;
459-
break;
460457
case Qt::Key_1:
461-
mappedKey = Key::Numpad_1;
462-
inferredModifiers |= Modifier::NumLock;
463-
break;
464458
case Qt::Key_2:
465-
mappedKey = Key::Numpad_2;
466-
inferredModifiers |= Modifier::NumLock;
467-
break;
468459
case Qt::Key_3:
469-
mappedKey = Key::Numpad_3;
470-
inferredModifiers |= Modifier::NumLock;
471-
break;
472460
case Qt::Key_4:
473-
mappedKey = Key::Numpad_4;
474-
inferredModifiers |= Modifier::NumLock;
475-
break;
476461
case Qt::Key_5:
477-
mappedKey = Key::Numpad_5;
478-
inferredModifiers |= Modifier::NumLock;
479-
break;
480462
case Qt::Key_6:
481-
mappedKey = Key::Numpad_6;
482-
inferredModifiers |= Modifier::NumLock;
483-
break;
484463
case Qt::Key_7:
485-
mappedKey = Key::Numpad_7;
486-
inferredModifiers |= Modifier::NumLock;
487-
break;
488464
case Qt::Key_8:
489-
mappedKey = Key::Numpad_8;
490-
inferredModifiers |= Modifier::NumLock;
491-
break;
492465
case Qt::Key_9:
493-
mappedKey = Key::Numpad_9;
466+
mappedKey = static_cast<Key>(static_cast<int>(Key::Numpad_0) + (key - Qt::Key_0));
494467
inferredModifiers |= Modifier::NumLock;
495468
break;
496469
// Operator and Enter keys have the same Qt key code regardless of NumLock state,

0 commit comments

Comments
 (0)