Color Management

[regevran]

I tried to read (a few times) colors management and failed. I think some background is missing in the documentation.
Specifically I have two annoying issues I would like to get rid of / change:

• When I select something with the mouse, all same text is selected too everywhere, and it keep being selected even if I open an editor or whatnot. The only way I know of to get rid of this selection is to select nothing with the mouse. This is annoying.
• Highlighted search results are in the wrong color for me - I can't find how to change it.

[Yaraslaut]

Hi,
if you do not want to see different highlight for the selected text by the double click you can use:

        word_highlight_other:
            foreground: CellForeground
            background: CellBackground
            foreground_alpha: 1.0
            background_alpha: 1.0

search result from the vim mode:

        # Search match highlighting. Similar to selection highlighting.
        search_highlight:
            foreground: '#00ffff'
            background: CellBackground
            foreground_alpha: 1.0
            background_alpha: 1.0

        # Search match highlighting (focused term). Similar to selection highlighting.
        search_highlight_focused:
            foreground: '#8b0000'
            background: '#ffffff'
            foreground_alpha: 1.0
            background_alpha: 1.0

[regevran]

Started on my own, found one-light

[Yaraslaut]

Unfortunately this will not resolve the issue for you, since you want to specify some specific color for some feature while palettes are used to define colors that are used across features, easiest way would be to create a custom color scheme, and in the future we will add customization to the existing color palettes

[regevran]

we will add customization to the existing color palettes

I suggested my help.
If you are willing to write some words about the load-order for example it might shorten my research.
If you add a few hints like: this and this and that should be changed it might help too.
I am looking at the various YAMLConfigReader::loadFromEntry - it doesn't seem to be too complicated to change.
A direction from you will ease this task, though.

[regevran]

I submitted a PR #1763.
It works for me locally, but I have no idea if this is indeed the required solution.

[Yaraslaut]

so when we load profile this is the entry point for the color palette:

Config.cpp:449       loadFromEntry(child, "colors", where.colors);

Color config can define one color palette or dark/light,
so the config itself holds the type using ColorConfig = std::variant<SimpleColorConfig, DualColorConfig>;
void YAMLConfigReader::loadFromEntry(YAML::Node const& node, std::string const& entry, ColorConfig& where) is used to figure out which one to load
and we are interested in what is happening next, in the function

void YAMLConfigReader::loadFromEntry(YAML::Node const& node,
                                     std::string const& entry,
                                     vtbackend::ColorPalette& where)

at the moment we check if this is one of the predefined pallets and return it, but what we need to do is to use default values to populate it and let loading to continue through the function

void YAMLConfigReader::loadFromEntry(YAML::Node const& node, vtbackend::ColorPalette& where)

[regevran]

I think that what you described matches my PR.