Add phpstan

Author: enumag

composer.json

@@ -24,6 +24,8 @@
         "nette/utils": "^3.0.0@alpha"
     },
     "require-dev": {
+        "nette/caching": "^3.0.0@alpha",
+        "nette/finder": "^3.0.0@alpha",
         "latte/latte": "^3.0.0@alpha",
         "tracy/tracy": "^2.4.0"
     },

phpstan.neon

@@ -0,0 +1,3 @@
+parameters:
+    ignoreErrors:
+        - '#^Arachne\\Codeception\\Http\\Request::__construct\(\) does not call parent constructor from Nette\\Http\\Request#'

src/Module/NetteApplicationModule.php

@@ -21,6 +21,14 @@
  */
 class NetteApplicationModule extends Framework
 {
+    /**
+     * @var NetteConnector
+     */
+    public $client;
+
+    /**
+     * @var array
+     */
     protected $config = [
         'followRedirects' => true,
     ];
@@ -37,11 +45,15 @@ public function _beforeSuite($settings = [])
 
     public function _before(TestInterface $test)
     {
-        $this->configFiles = null;
         $this->client = new NetteConnector();
-        $this->client->setContainerAccessor(function () {
-            return $this->getModule(NetteDIModule::class)->getContainer();
-        });
+        $this->client->setContainerAccessor(
+            function () {
+                /** @var NetteDIModule $diModule */
+                $diModule = $this->getModule(NetteDIModule::class);
+
+                return $diModule->getContainer();
+            }
+        );
         $this->client->followRedirects($this->config['followRedirects']);
 
         parent::_before($test);
@@ -74,8 +86,10 @@ public function seeRedirectTo($url)
         if ($this->client->isFollowingRedirects()) {
             $this->fail('Method seeRedirectTo only works when followRedirects option is disabled');
         }
-        $request = $this->getModule(NetteDIModule::class)->grabService(IRequest::class);
-        $response = $this->getModule(NetteDIModule::class)->grabService(IResponse::class);
+        /** @var NetteDIModule $diModule */
+        $diModule = $this->getModule(NetteDIModule::class);
+        $request = $diModule->grabService(IRequest::class);
+        $response = $diModule->grabService(IResponse::class);
         if ($response->getHeader('Location') !== $request->getUrl()->getHostUrl().$url && $response->getHeader('Location') !== $url) {
             $this->fail('Couldn\'t confirm redirect target to be "'.$url.'", Location header contains "'.$response->getHeader('Location').'".');
         }

src/Module/NetteDIModule.php

@@ -53,7 +53,7 @@ class NetteDIModule extends Module
     private $configFiles;
 
     /**
-     * @var Container
+     * @var Container|null
      */
     private $container;
 

src/Tracy/Logger.php

@@ -22,8 +22,9 @@ class Logger extends Extension
         Events::TEST_ERROR => 'testError',
     ];
 
-    public function __construct()
+    public function __construct($config, $options)
     {
+        parent::__construct($config, $options);
         Debugger::$logDirectory = $this->getLogDir();
     }
 

tests.md

@@ -2,8 +2,9 @@ How to run tests
 ====
 
 ```
-# install php-cs-fixer
-composer global require friendsofphp/php-cs-fixer "^2.0.0@dev"
+# install php-cs-fixer and phpstan
+composer global require friendsofphp/php-cs-fixer
+composer global require phpstan/phpstan
 
 # go to the project's root directory, but NOT the tests subdirectory 
 cd <project_dir>
@@ -17,6 +18,9 @@ php-cs-fixer fix --dry-run
 # fix coding style
 php-cs-fixer fix
 
+# static analysis
+phpstan analyse --level=4 --configuration=phpstan.neon src tests
+
 # run tests
 sh ./tests/run.sh
 ```

tests/integration/src/ApplicationTest.php

@@ -10,6 +10,8 @@
  */
 class ApplicationTest extends Unit
 {
+    protected $tester;
+
     public function testApplication()
     {
         $this->assertInstanceOf(Application::class, $this->tester->grabService(Application::class));

tests/integration/src/DITest.php

@@ -10,6 +10,8 @@
  */
 class DITest extends Unit
 {
+    protected $tester;
+
     public function testContainer()
     {
         $this->assertInstanceOf(Container::class, $this->tester->grabService(Container::class));