Skip to content

Commit 3f40222

Browse files
committed
QA: update ruleset
1 parent f1664e2 commit 3f40222

File tree

3 files changed

+9
-24
lines changed

3 files changed

+9
-24
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
},
2424
"require-dev": {
2525
"mockery/mockery": "^1.3.1",
26-
"ninjify/qa": "^0.9.0",
26+
"ninjify/qa": "^0.12",
2727
"ninjify/nunjuck": "^0.4",
2828
"phpstan/extension-installer": "^1.0",
2929
"phpstan/phpstan-deprecation-rules": "^0.12.2",

ruleset.xml

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,20 @@
11
<?xml version="1.0"?>
22
<ruleset>
33
<!-- Contributte Coding Standard -->
4-
<rule ref="./vendor/ninjify/coding-standard/contributte.xml">
5-
<exclude name="SlevomatCodingStandard.ControlStructures.RequireTernaryOperator.TernaryOperatorNotUsed"/>
6-
<exclude name="SlevomatCodingStandard.ControlStructures.ControlStructureSpacing.IncorrectLinesCountBeforeControlStructure"/>
7-
<exclude name="SlevomatCodingStandard.ControlStructures.ControlStructureSpacing.IncorrectLinesCountAfterControlStructure"/>
8-
<exclude name="SlevomatCodingStandard.ControlStructures.ControlStructureSpacing.IncorrectLinesCountAfterLastControlStructure"/>
9-
<exclude name="SlevomatCodingStandard.ControlStructures.RequireMultiLineTernaryOperator.MultiLineTernaryOperatorNotUsed"/>
10-
</rule>
4+
<rule ref="./vendor/ninjify/coding-standard/contributte.xml"/>
115

126
<!-- Specific -->
137
<rule ref="SlevomatCodingStandard.Files.TypeNameMatchesFileName">
148
<properties>
15-
<property name="rootNamespaces" type="array" value="
16-
src=>Nettrine\ORM,
17-
tests/cases=>Tests\Cases,
18-
tests/fixtures=>Tests\Fixtures,
19-
tests/toolkit=>Tests\Toolkit
20-
"/>
9+
<property name="rootNamespaces" type="array">
10+
<element key="src" value="Nettrine\ORM"/>
11+
<element key="tests/cases" value="Tests\Cases"/>
12+
<element key="tests/fixtures" value="Tests\Fixtures"/>
13+
<element key="tests/toolkit" value="Tests\Toolkit"/>
14+
</property>
2115
</properties>
2216
</rule>
2317

24-
<!-- Tests specific -->
25-
<rule ref="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.UselessDocComment">
26-
<exclude-pattern>/tests/cases</exclude-pattern>
27-
</rule>
28-
2918
<!--Exclude folders -->
3019
<exclude-pattern>/tests/tmp</exclude-pattern>
3120
</ruleset>

src/Mapping/ContainerEntityListenerResolver.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,7 @@ public function resolve($className)
6161
return $this->instances[$className];
6262
}
6363

64-
if (($service = $this->container->getByType($className, false))) {
65-
$this->instances[$className] = $this->container->getByType($className);
66-
} else {
67-
$this->instances[$className] = new $className();
68-
}
64+
$this->instances[$className] = $this->container->getByType($className, false) ?? new $className();
6965

7066
return $this->instances[$className];
7167
}

0 commit comments

Comments
 (0)