fix: always normalize flags fully

marionebl · marionebl · commit 3d71cd3bf519 · 2017-12-04T09:49:41.000+01:00
diff --git a/@commitlint/cli/src/cli.js b/@commitlint/cli/src/cli.js
@@ -91,11 +91,13 @@ async function main(options) {
 	}
 }
 
-function normalizeFlags(flags) {
+function normalizeFlags(raw) {
+	const flags = merge({}, raw);
+
 	// The `edit` flag is either a boolean or a string but we are only allowed
 	// to specify one of them in minimist
 	if (flags.edit === '') {
-		return merge({}, flags, {edit: true, e: true});
+		merge(flags, {edit: true, e: true});
 	}
 
 	if (!('format' in flags)) {

Original file line number	Diff line number	Diff line change
`@@ -91,11 +91,13 @@ async function main(options) {`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`
`94`		`-function normalizeFlags(flags) {`
	`94`	`+function normalizeFlags(raw) {`
	`95`	`+ const flags = merge({}, raw);`
	`96`	`+`
`95`	`97`	// The `edit` flag is either a boolean or a string but we are only allowed
`96`	`98`	`// to specify one of them in minimist`
`97`	`99`	`if (flags.edit === '') {`
`98`		`- return merge({}, flags, {edit: true, e: true});`
	`100`	`+ merge(flags, {edit: true, e: true});`
`99`	`101`	`}`
`100`	`102`
`101`	`103`	`if (!('format' in flags)) {`