Skip to content

Commit ea75778

Browse files
alsmadi99Mohammad Alsmadi
andauthored
fix: add TypeScript support and configuration for pnpm scopes (#4544)
* fix: add TypeScript support and configuration for pnpm scopes * fix: update ESLint configuration to ignore 'dist' directory * refactor: remove dist directory and its associated files * fix: ensure TypeScript build outputs are included --------- Co-authored-by: Mohammad Alsmadi <[email protected]>
1 parent a1d4dbd commit ea75778

File tree

6 files changed

+23
-14
lines changed

6 files changed

+23
-14
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ package.json.lerna_backup
1212
/*.iml
1313
tsconfig.tsbuildinfo
1414
coverage
15+
dist
1516

1617
docs/.vitepress/dist
1718
docs/.vitepress/cache

@commitlint/config-pnpm-scopes/package.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,12 @@
4545
"@types/node": "^18.19.17",
4646
"typescript": "^5.2.2"
4747
},
48+
"exports": {
49+
".": {
50+
"import": "./dist/index.js",
51+
"require": "./dist/index.js",
52+
"types": "./dist/index.d.ts"
53+
}
54+
},
4855
"gitHead": "e82f05a737626bb69979d14564f5ff601997f679"
4956
}
Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
{
2+
"extends": "../../tsconfig.shared.json",
23
"compilerOptions": {
3-
"target": "ES2020",
4-
"module": "CommonJS",
5-
"declaration": true,
6-
"outDir": "dist",
7-
"rootDir": "/",
8-
"strict": true,
9-
"esModuleInterop": true
4+
"composite": true,
5+
"rootDir": "./",
6+
"outDir": "./dist"
107
},
11-
"include": ["/"]
8+
"include": ["*.ts"],
9+
"exclude": ["./dist/**/*"],
10+
"references": [{ "path": "../types" }]
1211
}

Dockerfile.ci

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ RUN yarn install --frozen-lockfile --network-timeout 100000 && \
88
# Commit lint CLI packages
99
npm pack @commitlint/cli && \
1010
npm pack @commitlint/config-validator && \
11+
npm pack @commitlint/config-pnpm-scopes && \
1112
npm pack @commitlint/config-nx-scopes && \
1213
npm pack @commitlint/ensure && \
1314
npm pack @commitlint/execute-rule && \

eslint.config.mjs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import typescriptEslint from '@typescript-eslint/eslint-plugin';
2-
import {createTypeScriptImportResolver} from 'eslint-import-resolver-typescript';
2+
import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescript';
33
import jest from 'eslint-plugin-jest';
4-
import {importX} from 'eslint-plugin-import-x';
4+
import { importX } from 'eslint-plugin-import-x';
55
import globals from 'globals';
66
import tsParser from '@typescript-eslint/parser';
77
import path from 'node:path';
8-
import {fileURLToPath} from 'node:url';
8+
import { fileURLToPath } from 'node:url';
99
import js from '@eslint/js';
10-
import {FlatCompat} from '@eslint/eslintrc';
10+
import { FlatCompat } from '@eslint/eslintrc';
1111

1212
const __filename = fileURLToPath(import.meta.url);
1313
const __dirname = path.dirname(__filename);
@@ -19,7 +19,7 @@ const compat = new FlatCompat({
1919

2020
export default [
2121
{
22-
ignores: ['**/lib/', '**/coverage/', '**/node_modules/', '**/fixtures/'],
22+
ignores: ['**/lib/', '**/coverage/', '**/node_modules/', '**/fixtures/', '**/dist/'],
2323
},
2424
importX.flatConfigs.typescript,
2525
...compat.extends('eslint:recommended', 'prettier'),

tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
{ "path": "@commitlint/travis-cli" },
2929
{ "path": "@commitlint/prompt" },
3030
{ "path": "@commitlint/cz-commitlint" },
31-
{ "path": "@commitlint/config-conventional" }
31+
{ "path": "@commitlint/config-conventional" },
32+
{ "path": "@commitlint/config-pnpm-scopes" }
3233
]
3334
}

0 commit comments

Comments
 (0)