turn on rule for preventing import cycles in plain JS

Author: stekycz

src/flow.js

@@ -4,6 +4,7 @@ module.exports = {
 	],
 	rules: {
 		'no-duplicate-imports': 'off', // to support separate imports of types
+		'import/no-cycle': 'off', // to support importing types
 		'flowtype/array-style-complex-type': 'off',
 		'flowtype/array-style-simple-type': 'off',
 		'flowtype/arrow-parens': ['error', 'always'],

src/import.js

@@ -37,7 +37,7 @@ module.exports = {
 			allowObject: true,
 		}],
 		'import/no-commonjs': 'error',
-		'import/no-cycle': 'off',
+		'import/no-cycle': 'error',
 		'import/no-default-export': 'off',
 		'import/no-deprecated': 'error',
 		'import/no-duplicates': 'error',

src/typescript.js

@@ -18,6 +18,7 @@ module.exports = {
 		},
 	],
 	rules: {
+		'import/no-cycle': 'off', // to support importing types/interfaces
 		'@typescript-eslint/adjacent-overload-signatures': 'error',
 		'@typescript-eslint/array-type': ['error', {
 			default: 'array-simple',

tests/flow.test.js

@@ -13,6 +13,7 @@ describe('Rules Configurations', () => {
 		const pluginRules = Object.keys(plugin.rules).map((ruleName) => `flowtype/${ruleName}`);
 		const overridenRuleNames = [
 			'no-duplicate-imports',
+			'import/no-cycle',
 		];
 
 		it('has configuration for all supported rules', () => {

tests/typescript.test.js

@@ -19,6 +19,7 @@ describe('Rules Configurations', () => {
 			'quotes',
 			'require-await',
 			'semi',
+			'import/no-cycle',
 		];
 
 		it('has configuration for all supported rules', () => {