Skip to content

Bug: PR Quality bot closes PRs even when checks pass #9073

@themachinehf

Description

@themachinehf

Bug Description

The PR Quality workflow (anti-slop) appears to have a bug where it closes PRs even when quality checks pass. I have submitted 3 PRs (#9070, #9071, #9072) for the same fix - adding mysql-client to Pterodactyl panel entrypoint.

All 3 PRs were closed by the bot with message: "This PR did not pass quality checks so it will be closed."

However:

  • The pr-quality check itself completes with SUCCESS
  • GitGuardian Security Checks pass
  • The actual anti-slop action times out on download

PR Details

Suggested Fix

The anti-slop action fails to download with:

Failed to download action 'https://api.github.com/repos/peakoss/anti-slop/tarball/85daca1880e9e1af197fc06ea03349daf08f4202'. 
Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.

This causes the check to not run properly. The workflow may need to handle action download failures more gracefully rather than closing the PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions