Fix allowedDomains condition in resize function

andrasbacsai · andrasbacsai · commit 6c1ce9c52cc4 · 2024-03-06T10:47:02.000+01:00
diff --git a/index.js b/index.js
@@ -17,7 +17,7 @@ async function resize(url) {
     const preset = "pr:sharp"
     const src = url.pathname.split("/").slice(2).join("/");
     const origin = new URL(src).hostname;
-    if (allowedDomains.includes("*") && !allowedDomains.includes(origin)) {
+    if (!allowedDomains.includes("*") && !allowedDomains.includes(origin)) {
         return new Response(`Domain (${origin}) not allowed. More details here: https://github.com/coollabsio/next-image-transformation`, { status: 403 });
     }
     const width = url.searchParams.get("width") || 0;

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ async function resize(url) {`
`17`	`17`	`const preset = "pr:sharp"`
`18`	`18`	`const src = url.pathname.split("/").slice(2).join("/");`
`19`	`19`	`const origin = new URL(src).hostname;`
`20`		`- if (allowedDomains.includes("*") && !allowedDomains.includes(origin)) {`
	`20`	`+ if (!allowedDomains.includes("*") && !allowedDomains.includes(origin)) {`
`21`	`21`	return new Response(`Domain (${origin}) not allowed. More details here: https://github.com/coollabsio/next-image-transformation`, { status: 403 });
`22`	`22`	`}`
`23`	`23`	`const width = url.searchParams.get("width") \|\| 0;`