8.98: fixed a bug where servers would send ERR_UNKNOWNCOMMAND after incoming numerics which were being sent due to the recent changes that allow numerics to be fired on connection objects.

            numerics are no longer sent to servers (not with the server as the target anyway).
            servers now do not send ERR_UNKNOWNCOMMAND to other registered servers, and all incoming numerics are ignored.

Author: cooper

INDEV

@@ -2506,10 +2506,10 @@ CHANGES:
 
         94. moved the remainder of the command handlers to the new API.
             removed the hideous old parameter parser.
-            RPL_UNKNOWNCOMMAND is now an event callback that is canceled by handler wrappers.
+            ERR_UNKNOWNCOMMAND is now an event callback that is canceled by handler wrappers.
 
         95. updated Fantasy for the new evented command handler.
-            fixed an issue where parameter parser errors would lead to RPL_UNKNOWNCOMMAND.
+            fixed an issue where parameter parser errors would lead to ERR_UNKNOWNCOMMAND.
             fixed a vulnerability where commands using echo or PRIVMSG could trigger additional fantasy commands.
 
         96. message object ->source now automatically determines source object.
@@ -2519,6 +2519,10 @@ CHANGES:
         97. silently ignore unhandled numerics from servers.
             removed the matcher identifier code as it was unused and causing problems for the '...' (synonymous with @rest) modifier.
 
+        98. fixed a bug where servers would send ERR_UNKNOWNCOMMAND after incoming numerics which were being sent due to the recent changes that allow numerics to be fired on connection objects.
+            numerics are no longer sent to servers (not with the server as the target anyway).
+            servers now do not send ERR_UNKNOWNCOMMAND to other registered servers, and all incoming numerics are ignored.
+            
 
 
 

TODO

@@ -137,7 +137,7 @@ Server linkage
     [*] Connection timers continue even after an ERROR message is received. Sometimes two
         timers may be ticking for the same server.
 
-    [*] SQUIT and CONNECT still do not work quite right, probably due to the above issues
+    [ ] SQUIT and CONNECT still do not work quite right, probably due to the above issues
         with connection timers.
 
     [ ] SQUIT and CONNECT probably do not accept server masks.
@@ -160,7 +160,7 @@ User commands that are in desperate need of rewriting
 
     [ ] WHO             needs to be evented, extensible, and fully supportive of WHOX
 
-    [ ] WHOIS           needs to be evented and extensible
+    [√] WHOIS           needs to be evented and extensible
 
 Other user commands
 ------------------------------------------------------------------------------------------

VERSION

@@ -1 +1 @@
-8.97
+8.98

modules/ircd.module/connection.module/connection.json

@@ -1,12 +1,12 @@
 {
-   "version" : "8.96",
+   "version" : "8.98",
    "name" : "ircd::connection",
+   "no_bless" : 1,
    "author" : {
       "website" : "https://github.com/cooper",
       "name" : "Mitchell Cooper"
    },
-   "no_bless" : 1,
-   "preserve_sym" : 1,
    "description" : "represents a connection to the server",
+   "preserve_sym" : 1,
    "package" : "connection"
 }

modules/ircd.module/connection.module/connection.pm

@@ -18,7 +18,7 @@ use 5.010;
 use parent 'Evented::Object';
 
 use Socket::GetAddrInfo;
-use Scalar::Util 'weaken';
+use Scalar::Util qw(weaken blessed);
 use utils qw(conf v notice);
 
 our ($api, $mod, $me, $pool);
@@ -32,14 +32,14 @@ sub init {
     # THIS IS ONLY USED FOR SERVERS AS OF 8 July 2014.
     $pool->on('connection.raw' => sub {
         my ($connection, $event, $data, @args) = @_;
-        return unless $connection->{type};
-        return unless $connection->{type}->isa('server');
+        return unless $connection->server;
         $connection->{type}->handle($data, \@args);
     }, name => 'high.level.handlers', priority => -100, with_eo => 1);
 
     # send unknown command. this is canceled by handlers.
     $pool->on('connection.message' => sub {
         my ($connection, $event, $msg) = @_;
+        return if $connection->server;
         $connection->numeric(ERR_UNKNOWNCOMMAND => $msg->raw_cmd);
         return;
     }, name => 'ERR_UNKNOWNCOMMAND', priority => -200, with_eo => 1);
@@ -108,10 +108,11 @@ sub handle {
     );
 
     # user events.
+    my $user = $connection->user;
     push @events,
-        [ $connection->{type}, message          => $msg ],
-        [ $connection->{type}, "message_${cmd}" => $msg ]
-    if $connection->{type} && $connection->{type}->isa('user');
+        [ $user, message          => $msg ],
+        [ $user, "message_${cmd}" => $msg ]
+    if $user;
 
     # fire with safe option.
     my $fire = $connection->prepare(@events)->fire('safe');
@@ -229,7 +230,7 @@ sub ready {
     }
 
     weaken($connection->{type}{conn} = $connection);
-    $connection->{type}->new_connection if $connection->{type}->isa('user');
+    $connection->{type}->new_connection if $connection->user;
     return $connection->{ready} = 1;
 }
 
@@ -251,8 +252,7 @@ sub sendfrom {
 sub sendme {
     my $connection = shift;
     my $source =
-        $connection->{type} && $connection->{type}->isa('server') ?
-        $me->{sid} : $me->{name};
+        $connection->server ? $me->{sid} : $me->{name};
     $connection->sendfrom($source, @_);
 }
 
@@ -283,7 +283,7 @@ sub early_reply {
 
 # end a connection. this must be foolproof.
 sub done {
-    my ($connection, $reason, $silent) = @_;
+    my ($connection, $reason) = @_;
     L("Closing connection from $$connection{ip}: $reason");
 
 
@@ -298,9 +298,8 @@ sub done {
 
     }
 
-    # I'm not sure where $silent is even used these days.
     # this is safe because ->send() is safe now.
-    $connection->send("ERROR :Closing Link: $$connection{host} ($reason)") unless $silent;
+    $connection->send("ERROR :Closing Link: $$connection{host} ($reason)");
 
     # remove from connection the pool if it's still there.
     # if the connection has reserved a nick, release it.
@@ -350,8 +349,11 @@ sub numeric {
         @response = sprintf $val, @_;
     }
 
-    # local user.
-    my $nick = ($connection->{type} || $connection)->{nick} // '*';
+    # ignore registered servers.
+    return if $connection->server;
+
+    # send.
+    my $nick = ($connection->user || $connection)->{nick} // '*';
     $connection->sendme("$num $nick $_") foreach @response;
 
     return 1;
@@ -362,7 +364,7 @@ sub numeric {
 ### CAPABILITIES ###
 ####################
 
-# has a capability
+# has a capability.
 sub has_cap {
     my ($connection, $flag) = (shift, lc shift);
     return unless $connection->{cap_flags};
@@ -372,7 +374,7 @@ sub has_cap {
     return;
 }
 
-# add a capability
+# add a capability.
 sub add_cap {
     my ($connection, @flags) = (shift, map { lc } @_);
     foreach my $flag (@flags) {
@@ -382,7 +384,7 @@ sub add_cap {
     return 1;
 }
 
-# remove a capability 
+# remove a capability.
 sub remove_cap {
     my ($connection, @flags) = (shift, map { lc } @_);
     return unless $connection->{cap_flags};
@@ -396,4 +398,22 @@ sub DESTROY {
     L("$connection destroyed");
 }
 
+#############
+### TYPES ###
+#############
+
+sub type { shift->{type} }
+
+sub user {
+    my $type = shift->{type};
+    blessed $type && $type->isa('user') or return;
+    return $type;
+}
+    
+sub server {
+    my $type = shift->{type};
+    blessed $type && $type->isa('server') or return;
+    return $type;
+}
+
 $mod

modules/ircd.module/ircd.json

@@ -1,12 +1,12 @@
 {
-   "version" : "8.95",
+   "version" : "8.98",
    "name" : "ircd",
-   "no_bless" : 1,
    "author" : {
       "website" : "https://github.com/cooper",
       "name" : "Mitchell Cooper"
    },
-   "description" : "main IRCd module",
+   "no_bless" : 1,
    "preserve_sym" : 1,
+   "description" : "main IRCd module",
    "package" : "ircd"
 }

modules/ircd.module/ircd.pm

@@ -505,7 +505,7 @@ sub handle_connect {
 sub handle_data {
     my ($stream, $buffer) = @_;
     my $connection = $pool->lookup_connection($stream) or return;
-    my $is_server  = $connection->{type} && $connection->{type}->isa('server');
+    my $is_server  = $connection->server;
 
     # fetch the values at which the limit was exceeded.
     my $overflow_1line = (my $max_in_line = conf('limit', 'bytes_line')  // 2048) + 1;
@@ -573,7 +573,7 @@ sub ping_check {
             next;
         }
 
-        my $type = $connection->{type}->isa('user') ? 'user' : 'server';
+        my $type = $connection->user ? 'user' : 'server';
         my $since_last = time - $connection->{last_response};
 
         # no incoming data for configured frequency.