6.96: solved an issue where some users may not be ->quit()ted during netsplit due to modification of the {users} array during iteration.

Author: cooper

INDEV

@@ -1915,4 +1915,6 @@ CHANGES:
         94. use server mode string for ->fire_command() in JOIN user command handler.
 
         95. handle modes from the local server rather than the user in Access module.
+        
+        96. solved an issue where some users may not be ->quit()ted during netsplit due to modification of the {users} array during iteration.
 

VERSION

@@ -1 +1 @@
-6.95
+6.96

lib/channel/mine.pm

@@ -30,7 +30,7 @@ sub localjoin {
     }
 
     names($channel, $user);
-    $user->handle("TOPIC $$channel{name}") if exists $channel->{topic};
+    $user->handle("TOPIC $$channel{name}") if $channel->{topic};
     $user->numeric('RPL_ENDOFNAMES', $channel->{name});
 
     # fire after join event.

lib/pool.pm

@@ -191,7 +191,8 @@ sub delete_user {
 
     # remove from server.
     # this isn't a very efficient way to do this.
-    @{ $user->{server}{users} } = grep { $_ != $user} @{ $user->{server}{users} };
+    my $users = $user->{server}{users};
+    @$users = grep { $_ != $user } @$users;
 
     # forget it.
     delete $user->{pool};

lib/server.pm

@@ -22,7 +22,7 @@ sub new {
 
 sub quit {
     my ($server, $reason, $why) = @_;
-    $why //= $server->{name}.q( ).$server->{parent}->{name};
+    $why //= $server->{name}.q( ).$server->{parent}{name};
 
     log2("server $$server{name} has quit: $reason");
 
@@ -33,7 +33,8 @@ sub quit {
     }
 
     # delete all of the server's users.
-    foreach my $user (@{ $server->{users} }) {
+    my @users = @{ $server->{users} };
+    foreach my $user (@users) {
         $user->quit($why);
     }