9.99: updated TIME and ADMIN commands to use the same global command

mechanism used by VERSION, UPDATE, RELOAD...

Author: cooper

INDEV

@@ -2879,4 +2879,6 @@ CHANGES:
         98. VERSION command now accurately displays version info for remote servers.
             improved reliablity of commands which take a remote server argument like VERSION, TIME, RELOAD, etc.
             commands which take a server mask parameter that can only match one server will now always match the local server if the query is "*".
-            
+
+        99. updated TIME and ADMIN commands to use the same global command mechanism used by VERSION, UPDATE, RELOAD...
+

VERSION

@@ -1 +1 @@
-9.98
+9.99

modules/Core/UserCommands.module/UserCommands.json

@@ -9,5 +9,5 @@
    "description" : "the core set of user commands",
    "name" : "Core::UserCommands",
    "package" : "M::Core::UserCommands",
-   "version" : "9.98"
+   "version" : "9.99"
 }

modules/Core/UserCommands.module/UserCommands.pm

@@ -60,7 +60,7 @@ our %user_commands = (
     VERSION => {
         code   => \&version,
         desc   => 'view server version information',
-        params => 'server(opt)'
+        params => 'server_mask(opt)'
     },
     LINKS => {
         code   => \&links,
@@ -182,8 +182,10 @@ our %user_commands = (
 );
 
 sub init {
-    $mod->register_global_command(name => 'version') or return;
-
+    $mod->register_global_command(name => $_) || return foreach qw(
+        version time admin
+    );
+    
     &add_join_callbacks;
     &add_whois_callbacks;
 
@@ -1158,7 +1160,7 @@ sub version {
 
     # if the server isn't me, forward it.
     if ($server != $me) {
-        $server->{location}->fire_command_data(version => $user, "\$$$server{sid}");
+        $server->{location}->fire_command(version => $user, $server);
         return 1;
     }
 

modules/JELP/Incoming.module/Incoming.json

@@ -1,13 +1,13 @@
 {
    "author" : {
-      "website" : "https://github.com/cooper",
-      "name" : "Mitchell Cooper"
+      "name" : "Mitchell Cooper",
+      "website" : "https://github.com/cooper"
    },
-   "description" : "basic set of JELP command handlers",
    "depends" : {
       "modules" : "JELP::Base"
    },
+   "description" : "basic set of JELP command handlers",
+   "name" : "JELP::Incoming",
    "package" : "M::JELP::Incoming",
-   "version" : "15.73",
-   "name" : "JELP::Incoming"
+   "version" : "15.93"
 }

modules/JELP/Incoming.module/Incoming.pm

@@ -145,14 +145,6 @@ my %scommands = (
         params  => '-tag.for(server) -source(user)  user',
         code    => \&whois
     },
-    ADMIN => {     # @for=sid        :uid     ADMIN
-        params  => '-tag.for(server) -source(user)',
-        code    => \&admin
-    },
-    TIME => {      # @for=sid        :uid     TIME
-        params  => '-tag.for(server) -source(user)',
-        code    => \&_time
-    },
     SNOTICE => {  # :sid SNOTICE   flag  :message
         params => '-source(server) any   :rest',
         code   => \&snotice
@@ -793,34 +785,6 @@ sub whois {
     return 1;
 }
 
-sub admin {
-    my ($server, $msg, $t_server, $user) = @_;
-    
-    # this message is for me.
-    if ($t_server->is_local) {
-        return $user->handle_unsafe('ADMIN');
-    }
-    
-    # === Forward ===
-    $msg->forward_to($t_server, admin => $user, $t_server);
-    
-    return 1;
-}
-
-sub _time {
-    my ($server, $msg, $t_server, $user) = @_;
-    
-    # this message is for me.
-    if ($t_server->is_local) {
-        return $user->handle_unsafe('TIME');
-    }
-    
-    # === Forward ===
-    $msg->forward_to($t_server, time => $user, $t_server);
-    
-    return 1;
-}
-
 sub snotice {
     my ($server, $msg, $s_serv, $notice, $message) = @_;
     (my $pretty = ucfirst $notice) =~ s/_/ /g;

modules/JELP/Outgoing.module/Outgoing.json

@@ -9,5 +9,5 @@
    "description" : "basic set of JELP outgoing commands",
    "name" : "JELP::Outgoing",
    "package" : "M::JELP::Outgoing",
-   "version" : "15.15"
+   "version" : "15.35"
 }

modules/JELP/Outgoing.module/Outgoing.pm

@@ -412,13 +412,12 @@ sub join_with_modes {
 
 sub admin {
     my ($to_server, $user, $t_server) = @_;
-    "\@for=$$t_server{sid} :$$user{uid} ADMIN"
+    ":$$user{uid} ADMIN \$$$t_server{sid}"
 }
 
-
 sub _time {
     my ($to_server, $user, $t_server) = @_;
-    "\@for=$$t_server{sid} :$$user{uid} TIME"
+    ":$$user{uid} TIME \$$$t_server{sid}"
 }
 
 sub snotice {
@@ -427,8 +426,8 @@ sub snotice {
 }
 
 sub version {
-    my ($to_server, $user, $target_server) = @_;
-    ":$$user{uid} VERSION \$$$target_server{sid}"
+    my ($to_server, $user, $t_server) = @_;
+    ":$$user{uid} VERSION \$$$t_server{sid}"
 }
 
 $mod