Copilot suggestions (#4239)

* update comment

* update comment

* update comment

* break after releasing selected worker

* typos

Author: btovar

batch_job/src/work_queue_factory.c

@@ -628,8 +628,8 @@ void remove_and_wait_all_workers( struct batch_queue *queue, struct itable *job_
 	/*
 	For non-local batch queues, we skip this be because our ability to
 	wait on removed jobs is unreliable.  For local jobs, we follow up
-	the friendly remove after 30s with an unfriendly kill, and we wait
-	for children to exit to ensure cleanup is complete.
+	the friendly remove after 30s with an unfriendly kill, then wait 5s,
+	and repeat this process until all workers exit, ensuring cleanup is complete.
 	*/
 
 	if(batch_queue_get_type(queue)==BATCH_QUEUE_TYPE_LOCAL) {

taskvine/src/bindings/python3/ndcctools/taskvine/dask_dag.py

@@ -186,7 +186,7 @@ def initialize_graph(self):
                 self._depth_of[task.key] = 0
                 self.set_result(task.key, task.value)
 
-        # Then initializa pwnding consumers if pruning is enabled
+        # Then initialize pending consumers if pruning is enabled
         if self.prune_depth > 0:
             self._initialize_pending_consumers()
             self._initialize_pending_producers()

taskvine/src/bindings/python3/ndcctools/taskvine/dask_executor.py

@@ -115,7 +115,7 @@ class DaskVine(Manager):
     # @param env_per_task  if true, each task individually expands its own environment. Must use environment option as a str.
     # @param progress_disable If True, disable progress bar
     # @param progress_label Label to use in progress bar
-    # @param reconstruct   Reconstrut graph based on annotated functions.
+    # @param reconstruct   Reconstruct graph based on annotated functions.
     # @param merge_size    When reconstructing a merge function, merge this many at a time
     # @param wrapper       Function to wrap dask calls. It should take as arguments (key, fn, *args). It should execute
     #                      fn(*args) at some point during its execution to produce the dask task result.

taskvine/src/manager/taskvine.h

@@ -908,7 +908,7 @@ whose contents are not returned to the manager by default.
 @param f A file object.
 @return A pointer to the contents of the file.  This will be freed with the file object.
 On error, returns NULL with errno set to: ENOENT if the file was not yet created,
-EAGAIN is the fetch failed but can be tried again, EIO if some unexpected I/O error occured.
+EAGAIN if the fetch failed but can be tried again, EIO if some unexpected I/O error occurred.
 */
 
 const char *vine_fetch_file(struct vine_manager *m, struct vine_file *f);

taskvine/src/manager/vine_manager.c

@@ -993,6 +993,7 @@ static int enforce_worker_eviction_interval(struct vine_manager *q)
 			/* evict this worker */
 			debug(D_VINE | D_NOTICE, "Intentionally evicting worker %s", w->hostname);
 			release_worker(q, w);
+			break;
 		}
 	}
 	list_delete(candidates_list);

taskvine/src/worker/vine_cache.c

@@ -954,7 +954,7 @@ int vine_cache_check_files(struct vine_cache *c, struct link *manager)
 			vine_cache_remove(c, cachename, manager);
 		}
 
-		/* Note that f may not longer be valid at this point */
+		/* Note that f may no longer be valid at this point */
 	}
 	return 1;
 }