👕 Manually fix lints

Author: cooperka

example/babel.config.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+module.exports = (api) => {
   api.cache(true);
   return {
     presets: ['babel-preset-expo'],

example/rn-cli.config.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 const blacklist = require('metro-config/src/defaults/blacklist');
 
 module.exports = {

example/src/GenericListExample.js

@@ -9,6 +9,18 @@ const EMPTY_LIST = Immutable.List();
 const MOCK_DELAY = 800;
 
 class GenericListExample extends Component {
+  defaultStateA = {
+    data: undefined, // Will be manually set on mount.
+    isLoading: false,
+    errorMsg: undefined,
+  };
+
+  defaultStateB = {
+    data: undefined, // Will be manually set on mount.
+    isLoading: false,
+    errorMsg: undefined,
+  };
+
   static propTypes = {
     ListComponent: PropTypes.oneOfType([PropTypes.func, PropTypes.element]).isRequired,
     listComponentProps: PropTypes.object.isRequired,
@@ -38,18 +50,6 @@ class GenericListExample extends Component {
     });
   }
 
-  defaultStateA = {
-    data: undefined, // Will be manually set on mount.
-    isLoading: false,
-    errorMsg: undefined,
-  };
-
-  defaultStateB = {
-    data: undefined, // Will be manually set on mount.
-    isLoading: false,
-    errorMsg: undefined,
-  };
-
   changeDataA(delay = 0) {
     const { listA } = this.state;
     const { dataMutatorA } = this.props;

package.json

@@ -66,7 +66,7 @@
     "babel-jest": "24.9.0",
     "eslint": "6.5.1",
     "eslint-config-airbnb": "18.0.1",
-    "eslint-config-cooperka": "1.0.2",
+    "eslint-config-cooperka": "1.0.4",
     "eslint-plugin-import": "2.18.2",
     "eslint-plugin-jsx-a11y": "6.2.3",
     "eslint-plugin-react": "7.16.0",

src/ImmutableListView/EmptyListView.js

@@ -3,6 +3,8 @@ import PropTypes from 'prop-types';
 import React, { PureComponent } from 'react';
 import { Text, ListView } from 'react-native';
 
+// ListView renders EmptyListView which renders an empty ListView. Cycle is okay here.
+// eslint-disable-next-line import/no-cycle
 import ImmutableListView from './ImmutableListView';
 
 import styles from '../styles';

src/ImmutableListView/ImmutableListView.js

@@ -6,6 +6,8 @@ import { Text, ListView, InteractionManager } from 'react-native';
 import styles from '../styles';
 import utils from '../utils';
 
+// ListView renders EmptyListView which renders an empty ListView. Cycle is okay here.
+// eslint-disable-next-line import/no-cycle
 import { EmptyListView } from './EmptyListView';
 
 /**
@@ -94,6 +96,7 @@ class ImmutableListView extends PureComponent {
         return utils.getValueFromKey(rowID, rowData);
       },
 
+      // eslint-disable-next-line react/destructuring-assignment
       sectionHeaderHasChanged: this.props.sectionHeaderHasChanged,
 
       getSectionHeaderData: (dataBlob, sectionID) => utils.getValueFromKey(sectionID, dataBlob),

src/ImmutableVirtualizedList/EmptyVirtualizedList.js

@@ -3,6 +3,8 @@ import PropTypes from 'prop-types';
 import React, { PureComponent } from 'react';
 import { Text, VirtualizedList } from 'react-native';
 
+// ListView renders EmptyListView which renders an empty ListView. Cycle is okay here.
+// eslint-disable-next-line import/no-cycle
 import ImmutableVirtualizedList from './ImmutableVirtualizedList';
 
 import styles from '../styles';

src/ImmutableVirtualizedList/ImmutableVirtualizedList.js

@@ -6,6 +6,8 @@ import { Text, VirtualizedList } from 'react-native';
 import styles from '../styles';
 import utils from '../utils';
 
+// ListView renders EmptyListView which renders an empty ListView. Cycle is okay here.
+// eslint-disable-next-line import/no-cycle
 import { EmptyVirtualizedList } from './EmptyVirtualizedList';
 
 /**

src/test-utils.js

@@ -13,7 +13,6 @@ import ImmutableVirtualizedList from './ImmutableVirtualizedList';
  * @see https://facebook.github.io/react-native/docs/listviewdatasource.html#constructor
  */
 const data = {
-
   EMPTY_DATA: Immutable.List(),
 
   LIST_DATA: Immutable.List([
@@ -64,11 +63,9 @@ const data = {
   ]),
 
   RANGE_DATA: Immutable.Range(3, 10, 3),
-
 };
 
 const renderers = {
-
   /**
    * @param {*} rowData
    */
@@ -88,11 +85,9 @@ const renderers = {
   renderSectionHeader(sectionData, category) {
     return <Text header>{`${category} (${sectionData.size} items)`}</Text>;
   },
-
 };
 
 const mocks = {
-
   /**
    * Mock ScrollView so that it doesn't contain any props when rendered by ListView.
    * This is useful for comparison between ListView and ImmutableListView.
@@ -103,17 +98,15 @@ const mocks = {
     jest.resetModules();
 
     // eslint-disable-next-line react/prop-types
-    const mockScrollView = (props) => React.createElement('ScrollView', {}, props.children);
+    const mockScrollView = ({ children }) => React.createElement('ScrollView', {}, children);
     jest.doMock('ScrollView', () => mockScrollView);
 
     // eslint-disable-next-line global-require
     return require('./ImmutableListView').default;
   },
-
 };
 
 const expectors = {
-
   expectToMatchSnapshotWithData(immutableData, shouldRenderSectionHeaders) {
     const renderSectionHeaderProps = shouldRenderSectionHeaders
       ? { renderSectionHeader: renderers.renderSectionHeader }
@@ -171,7 +164,6 @@ const expectors = {
 
     expect(immutableTree).toEqual(regularTree);
   },
-
 };
 
 export {

yarn.lock

@@ -2143,10 +2143,10 @@ [email protected]:
     object.assign "^4.1.0"
     object.entries "^1.1.0"
 
-[email protected].2:
-  version "1.0.2"
-  resolved "https://registry.yarnpkg.com/eslint-config-cooperka/-/eslint-config-cooperka-1.0.2.tgz#9c2294bfe276102d545c20b550d4e79da778e42b"
-  integrity sha512-YH/kPPgLDtHrhEIiVTgRY3dcpMMsSOCRAYPwbsfQMvt7UiZHp253G4lWK0hyu2sP2PO19xGn4Mhb8/NZV26muQ==
+[email protected].4:
+  version "1.0.4"
+  resolved "https://registry.yarnpkg.com/eslint-config-cooperka/-/eslint-config-cooperka-1.0.4.tgz#733c4ce66c74d3314f6970ced22515beb3e5c151"
+  integrity sha512-Aq9+NQ3E2e05wAl/rC7F7HLDJJH/GxEOkU+9Buulem+Bd3NnBvlSvJO4tbT5yNJjp9My4gvOwKv7biTtXlzaiQ==
 
 eslint-import-resolver-node@^0.3.2:
   version "0.3.2"