Honor ignored prefixes when clearing overlay

Prefix commands like C-u were clearing the Copilot overlay even when
their command symbols (e.g., 'universal-argument) were listed in
'copilot-clear-overlay-ignore-commands'.

* copilot.el (copilot--post-command): Check both 'this-command and the
command bound to the current key sequence.

* test/copilot-overlay-tests.el
(copilot-post-command-honors-key-binding-ignore)
(copilot-post-command-clears-when-not-ignored): New tests.

* Eask: Add script entry to run the tests.

Author: ultronozm

Eask

@@ -9,7 +9,7 @@
 
 (package-file "copilot.el")
 
-(script "test" "echo \"Error: no test specified\" && exit 1")
+(script "test" "emacs -Q --batch -L . -l ert -l test/copilot-overlay-tests.el -f ert-run-tests-batch-and-exit")
 
 (source 'gnu)
 (source 'melpa)

copilot.el

@@ -1223,6 +1223,9 @@ Copilot will show completions only if all predicates return t."
                        (or
                         (string-prefix-p "copilot-" (symbol-name this-command))
                         (member this-command copilot-clear-overlay-ignore-commands)
+                        (let ((key-command (key-binding (this-command-keys-vector) t)))
+                          (and (symbolp key-command)
+                               (member key-command copilot-clear-overlay-ignore-commands)))
                         (copilot--self-insert this-command)))))
     (copilot-clear-overlay)
     (when copilot--post-command-timer

test/copilot-overlay-tests.el

@@ -0,0 +1,66 @@
+;;; copilot-overlay-tests.el --- overlay command detection tests -*- lexical-binding: t; -*-
+
+(require 'cl-lib)
+(require 'ert)
+
+(unless (require 'f nil 'noerror)
+  (defun f-join (&rest segments)
+    (let ((path (or (car segments) "")))
+      (dolist (segment (cdr segments) path)
+        (setq path (expand-file-name segment path)))
+      path))
+  (provide 'f))
+
+(unless (featurep 'editorconfig)
+  (defvar editorconfig-indentation-alist nil)
+  (provide 'editorconfig))
+
+(unless (featurep 'track-changes)
+  (provide 'track-changes))
+
+(defconst copilot-test--root
+  (file-name-directory (directory-file-name (file-name-directory load-file-name)))
+  "Root directory of copilot.el tests.")
+
+(load-file (expand-file-name "copilot.el" copilot-test--root))
+(require 'copilot)
+
+(ert-deftest copilot-post-command-honors-key-binding-ignore ()
+  "copilot--post-command keeps the overlay when the key binding is ignored."
+  (with-temp-buffer
+    (let* ((copilot-clear-overlay-ignore-commands '(universal-argument-more))
+           (copilot-idle-delay nil)
+           (copilot--overlay (make-overlay (point) (point)))
+           (copilot--post-command-timer nil)
+           (this-command 'self-insert-command)
+           (real-this-command 'self-insert-command)
+           (cleared nil))
+      (cl-letf (((symbol-function 'this-command-keys-vector) (lambda () [?]))
+                ((symbol-function 'key-binding) (lambda (&rest _) 'universal-argument-more))
+                ((symbol-function 'copilot-clear-overlay)
+                 (lambda (&optional _) (setq cleared t)))
+                ((symbol-function 'copilot--self-insert) (lambda (&rest _) nil)))
+        (copilot--post-command)
+        (should-not cleared)))))
+
+(ert-deftest copilot-post-command-clears-when-not-ignored ()
+  "copilot--post-command clears overlay for non-ignored prefixes."
+  (with-temp-buffer
+    (let* ((copilot-clear-overlay-ignore-commands nil)
+           (copilot-idle-delay nil)
+           (copilot--overlay (make-overlay (point) (point)))
+           (copilot--post-command-timer nil)
+           (this-command 'self-insert-command)
+           (real-this-command 'self-insert-command)
+           (cleared nil))
+      (cl-letf (((symbol-function 'this-command-keys-vector) (lambda () [?]))
+                ((symbol-function 'key-binding) (lambda (&rest _) 'universal-argument-more))
+                ((symbol-function 'copilot-clear-overlay)
+                 (lambda (&optional _) (setq cleared t)))
+                ((symbol-function 'copilot--self-insert) (lambda (&rest _) nil)))
+        (copilot--post-command)
+        (should cleared)))))
+
+(provide 'copilot-overlay-tests)
+
+;;; copilot-overlay-tests.el ends here