Skip to content

Conversation

AntoineGS
Copy link
Contributor

This adds the ability to manually summon a NES instead of having them requested automatically.
Fixes #54

PR 3 of 3

@AntoineGS AntoineGS force-pushed the auto_trigger_config branch 3 times, most recently from 10a6d52 to 69753dd Compare September 12, 2025 17:17
@Xuyuanp
Copy link
Contributor

Xuyuanp commented Sep 15, 2025

looks like it's a duplicate of #53

@AntoineGS
Copy link
Contributor Author

It's a branch off the other PR but this one has an extra commit to keep the features separate.

@tris203
Copy link
Collaborator

tris203 commented Sep 23, 2025

I think this is confusing.

Are you suggesting that you would set up a keymap to trigger the first NES. then just go on a roll with auto triggers?

If so, then these variable names arent clear to me

@AntoineGS
Copy link
Contributor Author

It would be 100% manual when auto-trigger is false. The existing keymaps to accept the NES today would also be used to trigger the NES. So the first apply_pending_nes requests a NES, the second would apply it. If the user wants another NES, they would again call apply_pending_nes.
I can write a test or two if you would like to see it in practice!

@tris203
Copy link
Collaborator

tris203 commented Sep 23, 2025

I see now

A test would be great.
We can bike shed the option name after

I think in my head this makes sense flipped

So the option being
manual_trigger and false by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto_trigger option
3 participants