Skip to content

Commit ba3098b

Browse files
author
copyleftdev
committed
fix: resolve linting issues for CI/CD pipeline
- Fixed unchecked error return value in generate.go - Removed unused simulateGeneration function - Removed unused generateDemoData function - Added proper error handling for MarkFlagRequired - Build verified to work correctly after cleanup This should resolve the remaining Code Quality job failures.
1 parent 14f3eb8 commit ba3098b

File tree

2 files changed

+3
-87
lines changed

2 files changed

+3
-87
lines changed

internal/cli/generate.go

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,9 @@ func init() {
6262
generateCmd.Flags().IntVar(&minBatchSize, "min-batch-size", 1, "minimum batch size before giving up")
6363

6464
// Mark required flags
65-
generateCmd.MarkFlagRequired("spec")
65+
if err := generateCmd.MarkFlagRequired("spec"); err != nil {
66+
panic(err) // This should never happen during initialization
67+
}
6668
}
6769

6870
func runGenerate(cmd *cobra.Command, args []string) error {
@@ -317,27 +319,6 @@ func runGeneration(job *types.GenerationJob, timeout time.Duration) error {
317319
return nil
318320
}
319321

320-
func simulateGeneration(job *types.GenerationJob, timeout time.Duration) error {
321-
if !IsQuiet() {
322-
fmt.Printf("🚀 Generation started (Job ID: %s)\n", job.ID)
323-
fmt.Printf("⏱️ This is a simulation - actual implementation coming soon!\n")
324-
fmt.Printf("📊 Would generate %d records to: %s\n", job.Progress.Target, job.OutputPath)
325-
fmt.Printf("🤖 Would use model: %s at %s\n", job.Spec.Model.Name, job.Spec.Model.Endpoint)
326-
fmt.Println()
327-
328-
// Simulate some progress
329-
for i := 0; i < 5; i++ {
330-
time.Sleep(200 * time.Millisecond)
331-
progress := (i + 1) * 20
332-
fmt.Printf("📈 Progress: %d%% (%d/%d records)\n", progress, progress*job.Progress.Target/100, job.Progress.Target)
333-
}
334-
335-
fmt.Printf("\n✅ Generation completed successfully!\n")
336-
fmt.Printf("📁 Output written to: %s\n", job.OutputPath)
337-
}
338-
339-
return nil
340-
}
341322

342323
func generateJobID() string {
343324
return fmt.Sprintf("job_%d", time.Now().Unix())

internal/llm/client.go

Lines changed: 0 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -96,71 +96,6 @@ func (c *OllamaClient) GenerateBasic(ctx context.Context, spec *types.Specificat
9696
return records, nil
9797
}
9898

99-
// generateDemoData generates realistic demo data without requiring Ollama
100-
func (c *OllamaClient) generateDemoData(spec *types.Specification, count int) []types.Record {
101-
records := make([]types.Record, 0, count)
102-
103-
// Sample realistic data for medical/healthcare domain
104-
firstNames := []string{"John", "Jane", "Michael", "Sarah", "David", "Lisa", "Robert", "Emily", "James", "Ashley"}
105-
lastNames := []string{"Smith", "Johnson", "Williams", "Brown", "Jones", "Garcia", "Miller", "Davis", "Rodriguez", "Martinez"}
106-
107-
for i := 0; i < count; i++ {
108-
record := make(types.Record)
109-
110-
for _, field := range spec.Dataset.Fields {
111-
switch field.Type {
112-
case "string":
113-
if field.Pattern != "" {
114-
record[field.Name] = c.generatePatternString(field.Pattern, i)
115-
} else if field.Name == "first_name" {
116-
record[field.Name] = firstNames[i%len(firstNames)]
117-
} else if field.Name == "last_name" {
118-
record[field.Name] = lastNames[i%len(lastNames)]
119-
} else {
120-
record[field.Name] = fmt.Sprintf("sample_%s_%d", field.Name, i)
121-
}
122-
case "email":
123-
record[field.Name] = fmt.Sprintf("%s.%[email protected]",
124-
firstNames[i%len(firstNames)], lastNames[i%len(lastNames)])
125-
case "integer":
126-
if len(field.Range) == 2 {
127-
record[field.Name] = field.Range[0] + (i % (field.Range[1] - field.Range[0]))
128-
} else {
129-
record[field.Name] = i + 1
130-
}
131-
case "float":
132-
if len(field.Range) == 2 {
133-
baseValue := float64(field.Range[0])
134-
rangeSize := float64(field.Range[1] - field.Range[0])
135-
record[field.Name] = baseValue + (float64(i%100)/100.0)*rangeSize
136-
} else {
137-
record[field.Name] = float64(i) * 10.5
138-
}
139-
case "boolean":
140-
record[field.Name] = i%2 == 0
141-
case "enum":
142-
if len(field.Values) > 0 {
143-
record[field.Name] = field.Values[i%len(field.Values)]
144-
}
145-
case "date":
146-
// Generate dates in the past 30 years
147-
baseDate := time.Now().AddDate(-30, 0, 0)
148-
daysToAdd := i * 365 // Spread across years
149-
record[field.Name] = baseDate.AddDate(0, 0, daysToAdd).Format("2006-01-02")
150-
case "datetime":
151-
record[field.Name] = time.Now().Add(-time.Duration(i) * time.Hour).Format(time.RFC3339)
152-
case "array":
153-
record[field.Name] = []string{fmt.Sprintf("item_%d_1", i), fmt.Sprintf("item_%d_2", i)}
154-
default:
155-
record[field.Name] = fmt.Sprintf("sample_%s_%d", field.Type, i)
156-
}
157-
}
158-
159-
records = append(records, record)
160-
}
161-
162-
return records
163-
}
16499

165100
// generatePatternString generates a string that matches a regex pattern
166101
func (c *OllamaClient) generatePatternString(pattern string, seed int) string {

0 commit comments

Comments
 (0)