Commit 1809f6e
feat: add JSON Stream (NDJSON) body processor (#1563)
* fix(deps): update module golang.org/x/net to v0.45.0 [security] (#1487)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(deps): update go modules in go.mod (#1433)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* docs(actions): update format and add package (#1475)
* docs(actions): update format and add package
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* fix: update documentation for package
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* fix: go fmt
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
---------
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* fix: add A-Z to auditlog (#1479)
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* fix: SecRuleUpdateActionById should replace disruptive actions (#1471)
* fix: SecRuleUpdateActionById should replace disruptive actions
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* fix: multiphase test with bad expectations
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* tests: improve coverage on engine
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* refactor: address SecRuleUpdateActionById review comments (#1484)
* Initial plan
* Address code review comments: improve documentation, fix double parsing, and fix range logic
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* Refactor: Extract hasDisruptiveActions helper to avoid code duplication
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* docs: Improve applyParsedActions documentation
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* docs: Clarify body parsing logic in SetRawRequest
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* refactor: address review comments on SecRuleUpdateActionById
- Rename ClearActionsOfType to ClearDisruptiveActions
- Add comments explaining quote trimming in action parsing
- Remove empty line after function brace in updateActionBySingleID
- Split engine_test.go: move output/helper tests to engine_output_test.go
* Apply suggestions from code review
Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
* fix: use index-based iteration for SecRuleUpdateActionById range updates
The range loop variable copied each Rule, so modifications to disruptive
actions were lost. Use index-based iteration to modify rules in place.
Also adds a test case exercising the range update path.
---------
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
* refactor: remove root package dependency on experimental (#1494)
* refactor: remove root package dependency on experimental
Replace experimental.Options with corazawaf.Options in waf.go, breaking
the import cycle that prevented the experimental package from importing
the root coraza package. This unblocks PR #1478 and lets experimental
helpers use coraza.WAFConfig with proper type safety instead of any.
* Update waf.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* chore: min go version to 1.25 (#1497)
* No content wants no body
* Update .github/workflows/regression.yml
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
* one more place
---------
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
* feat: add optional rule observer callback to WAF config (#1478)
* feat: add optional rule observer callback to WAF config
Introduce an optional rule observer callback that is invoked for each rule successfully added to the WAF during initialization.
The observer receives rule metadata via the existing RuleMetadata interface.
* Move to the experimental package
* Do not use reflection to keep the compatibility with older Go versions
* Use coraza.WAFConfig, move the test to where it belongs.
---------
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
Co-authored-by: José Carlos Chávez <jcchavezs@gmail.com>
* feat: add WAFWithRules interface with RulesCount() (#1492)
Add WAFWithRules interface with RulesCount()
* fix(deps): update module golang.org/x/net to v0.51.0 [security] (#1502)
* fix(deps): update module golang.org/x/net to v0.51.0 [security]
* chore: update go.work to 1.25.0
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* chore: update golang to 1.25.0
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
---------
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* chore(deps): update module golang.org/x/net to v0.51.0 [security] (#1506)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix: lowercase regex patterns for case-insensitive variable collections (#1505)
* fix: lowercase regex patterns for case-insensitive variable collections
When a rule uses regex-based variable selection (e.g. TX:/PATTERN/),
the regex pattern was compiled from the raw uppercase string before
any case normalization. Since TX collection keys are stored lowercase,
the uppercase regex would never match, causing rules like CRS 922110
(which uses TX:/MULTIPART_HEADERS_CONTENT_TYPES_*/) to silently fail.
Now AddVariable and AddVariableNegation lowercase the regex pattern
before compilation for case-insensitive variables, matching the
existing behavior for string keys in newRuleVariableParams.
* chore: update coreruleset to v4.24.0
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
---------
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* chore: update libinjection-go and deps (#1496)
* chore: update libinjection-go and deps
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* chore: update coreruleset v4.24.0
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
---------
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* fix: ctl:ruleRemoveTargetById to support whole-collection exclusion (#1495)
* Initial plan
* Fix ruleRemoveTargetById to support removing entire collection (empty key)
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* feat: add SecRequestBodyJsonDepthLimit directive (#1110)
* feat: add SecRequestBodyJsonDepthLimit directive
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* Apply suggestions from code review
* fix: mage format
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* Update internal/bodyprocessors/json_test.go
* Update internal/bodyprocessors/json_test.go
* fix: bad char
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* fix: gofmt
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* docs: add clarifying comments for JSON recursion limit behavior
- Explain why ResponseBodyRecursionLimit = -1 (unlimited for responses)
- Document dual purpose of body reading (TX vars + ARGS_POST)
- Clarify DoS protection mechanism in readItems()
- Note how negative values bypass recursion check
* fix: address PR review comments for JSON depth limit
- Always enforce a positive recursion limit: change ResponseBodyRecursionLimit
from -1 (unlimited) to 1024, matching the request body default
- Rename test case "broken1" to "unbalanced_brackets" for clarity
- Extract error check from the key iteration loop in TestReadJSON
* test: add benchmarks for gjson.Valid pre-validation overhead
Measures the cost of gjson.Valid() in the full readJSON pipeline.
gjson.Parse is lazy (~9ns), so the real overhead is Valid vs the
readItems traversal. Results show ~10-16% overhead for validation,
which is acceptable for WAF safety. No single-pass alternative
exists in the gjson API.
* Apply suggestions from code review
* Apply suggestion from @fzipi
---------
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Co-authored-by: José Carlos Chávez <jcchavezs@gmail.com>
* fix: update constants for recursion limit (#1512)
* fix: conflate the constants for recursion limit
* fix: value setting
* chore: remove panic from seclang compiler (#1514)
* Initial plan
* fix: replace panic with error return in parser.go evaluateLine
Co-authored-by: jptosso <1236942+jptosso@users.noreply.github.com>
* fix: revert go.sum changes - do not modify go.sum files in this PR
Co-authored-by: jptosso <1236942+jptosso@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jptosso <1236942+jptosso@users.noreply.github.com>
* ci: reduce regression matrix from 128 to 15 jobs (#1522)
Replace dynamic 64-permutation tag matrix with a curated static list
of 13 build-flag combinations. Run all combos on Go 1.25.x and only
baseline + kitchen-sink on Go 1.26.x.
Add concurrency groups to regression, lint, tinygo, and codeql
workflows so stale PR runs are auto-cancelled on new pushes.
* feat: ignore unexpected EOF in MIME multipart request body processor (#1453)
* Ignore unexpected EOF in MIME multipart request body processor
We need this behavior since we need to process an incomplete MIME multipart
request body when SecRequestBodyLimitAction is set to ProcessPartial.
* fix: add copilot code review comments
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
---------
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Co-authored-by: José Carlos Chávez <jcchavezs@gmail.com>
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
Co-authored-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* fix: set changed flag in removeComments and escapeSeqDecode (#1532)
Fix two bugs where transformation functions modified the input string
but did not report changed=true:
- removeComments: entering a C-style (/* */) or HTML (<!-- -->)
comment block did not set changed=true, causing the multi-match
optimization to skip the transformed result.
- escapeSeqDecode: unrecognized escape sequences (e.g. \z) dropped
the backslash but did not set changed=true.
Add test coverage for both fixes including a new remove_comments_test.go
and an additional unrecognized-escape test case for escape_seq_decode.
* perf: use map for ruleRemoveByID for O(1) lookup (#1524)
* perf: use map for ruleRemoveByID for O(1) lookup
Replace []int slice with map[int]struct{} for the per-transaction
rule exclusion list. The rule evaluation loop checks this list for
every rule in every phase, making O(1) map lookup significantly
faster than O(n) linear scan when rules are excluded via ctl actions.
* test: add TestRemoveRuleByID for map-based rule exclusion
* bench: add BenchmarkRuleEvalWithRemovedRules
* refactor: use real unconditionalMatch operator from registry in tests
* Fix HTTP middleware to process all Transfer-Encoding values (#1518)
* Fix HTTP middleware to process all Transfer-Encoding values
Co-authored-by: jptosso <1236942+jptosso@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jptosso <1236942+jptosso@users.noreply.github.com>
Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
* fix(deps): update module golang.org/x/sync to v0.20.0 in go.mod (#1543)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: optimize ruleRemoveById range handling store ranges instead of expanding to int slices (#1538)
* Initial plan
* Optimize ruleRemoveById range handling to avoid generating massive int slices
- Replace rangeToInts (which allocated []int of all matching rule IDs) with
parseRange and parseIDOrRange helpers that return start/end integers
- For ctlRuleRemoveByID with ranges: store the range in
Transaction.ruleRemoveByIDRanges ([][2]int) and check it in the rule
evaluation loop, avoiding both the intermediate []int and potentially
large map expansions
- For ctlRuleRemoveTargetByID: iterate rules once directly, eliminating
the intermediate []int allocation
- Add RemoveRuleByIDRange method to Transaction
- Reset ruleRemoveByIDRanges on transaction pool reuse
- Replace TestCtlParseRange with TestCtlParseIDOrRange to test the new helpers
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* Improve test coverage for range-based rule removal
- Add TestRemoveRuleByIDRange in transaction_test.go:
- range is stored in ruleRemoveByIDRanges
- rules in range are skipped during Eval
- multiple ranges work correctly
- ruleRemoveByIDRanges is reset on transaction pool reuse
- Add TestCtlParseRange in ctl_test.go to cover parseRange directly
(including the no-separator and start>end error paths)
- Add GetRuleRemoveByIDRanges() accessor on Transaction for cross-package
test assertions
- Enhance "ruleRemoveById range" TestCtl case to verify the range is stored
- Add "ruleRemoveTargetById range" TestCtl case to verify range path works
Coverage changes:
parseRange: 83.3% → 100%
parseIDOrRange: 100% (unchanged)
RemoveRuleByIDRange: 0% → 100%
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* fix(testing): Correct use of ProcessURI in Benchmarks (#1546)
* perf: prefix-based transformation cache with inline values (#1544)
Redesign the transformation cache to share intermediate results across
rules with common transformation prefixes (e.g. rules using
t:lowercase,t:urlDecodeUni reuse the t:lowercase result cached by an
earlier rule using just t:lowercase).
Key changes:
- Add transformationPrefixIDs to Rule for backward prefix search
- Cache every intermediate transformation step, not just the final result
- Store cache values inline (not pointers) to avoid heap allocations
- Fix ClearTransformations (t:none) to reset transformationsID
Benchmarked against full CRS v4 ruleset (8 runs, benchstat):
Allocations: -2% (small) to -19% (30 params)
Memory: -2% (small) to -12% (30 params)
Timing: -5% (small/large), neutral (medium)
No regressions on any metric.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* perf: bulk-allocate MatchData in collection Find methods (#1530)
* perf: bulk-allocate MatchData in collection Find methods
Pre-allocate a contiguous []corazarules.MatchData buffer and take
pointers into it instead of individually heap-allocating each
MatchData. This reduces per-result allocations from N to 2 (one buf
slice + one result slice), improving GC pressure for large result
sets.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* perf: avoid double regex evaluation in FindRegex
Collect matching data slices during the counting pass so the second
pass only iterates over already-matched entries, eliminating redundant
MatchString calls.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* bench: add FindAll/FindRegex/FindString benchmarks
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
* perf: use FindStringSubmatchIndex to avoid capture allocations (#1547)
* perf: use FindStringSubmatchIndex to avoid capture allocations
Replace FindStringSubmatch (allocates a []string slice per match) with
FindStringSubmatchIndex (returns index pairs). Substrings passed to
CaptureField become slices of the original input — zero allocation.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* test: add BenchmarkRxCapture for submatch allocation comparison
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* fix(DetectionOnly): fixed RelevantOnly audit logs, improved matchedRules (#1549)
* add detectedInterruption var for DetectionOnly mode
* IsDetectionOnly, refactor, populate matchedRules
* nit
* Apply suggestions from code review
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
---------
Co-authored-by: Romain SERVIERES <romain@madeformed.com>
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
* fix(deps): update module golang.org/x/net to v0.52.0 in go.mod (#1553)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* ci: increase fuzztime (#1554)
* more fuzztime
* go mod
* chore(ci): harden GHA workflows with least-privilege permissions (#1559)
- Add top-level `permissions: {}` (deny-all) to every workflow
- Add scoped per-job permissions granting only what each job needs
- Fix expression injection in regression.yml by using env instead of
inline shell interpolation for BUILD_TAGS
- Restrict regression.yml pull_request trigger to main branch only
- Add explicit permissions to fuzz.yml (issues: write for failure reports)
- Add security-events: write to CodeQL workflow
* feat: enable regex memoize by default (#1540)
* feat: enable regex memoize by default
Memoization of regex and aho-corasick builders was previously opt-in via
the `memoize_builders` build tag. Most users didn't know to enable it,
missing a critical performance optimization.
This commit:
- Enables memoization by default (opt-out via `coraza.no_memoize` tag)
- Refactors internal/memoize from package-level Do() to Memoizer struct
- Adds Memoizer interface to plugintypes.OperatorOptions
- Wires WAF's Memoizer through to all operator and rule consumers
- Replaces `memoize_builders` build tag with `coraza.no_memoize` opt-out
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* docs: document cache tradeoffs and add noop memoize test
- Update README and memoize README to document global cache behavior
and point to WAF.Close() for live-reload scenarios.
- Add test file for coraza.no_memoize build variant to verify no-op
behavior.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* feat: add WAF.Close() with per-owner memoize cache tracking and scale benchmarks (#1541)
* feat: add WAF.Close() with per-owner memoize cache tracking
Add WAFCloser interface and per-owner tracking to the memoize cache so
that long-lived processes can release compiled regex entries when a WAF
instance is destroyed. Each WAF gets a uint64 ID; Release() removes the
owner and tombstones entries with no remaining owners.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* test: add memoize scale benchmarks and CRS integration tests
Add benchmarks demonstrating memoize value at scale (1-100 WAFs × 300
patterns) and CRS integration tests verifying Close() releases memory.
Results show ~27x speedup for 100 WAFs and 27MiB released on Close().
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* test: add WAF.Close() calls to e2e and CRS tests
Demonstrate proper WAFCloser usage in integration tests: e2e test,
CRS FTW test, CRS benchmarks, and crsWAF helper.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* test: extend coraza.no_memoize coverage in noop_test.go (#1555)
* Initial plan
* test: extend noop_test.go coverage for coraza.no_memoize build tag
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* fix: check error return of m.Do in benchmark to resolve errcheck lint failure (#1556)
* Initial plan
* fix: check error return of m.Do in benchmark test to fix errcheck lint
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* fix: skip memoize scale tests in short mode
The scale tests (TestMemoizeScaleMultipleOwners, TestCacheGrowthWithoutClose,
TestCacheBoundedWithClose) compile hundreds of regexes across many owners/cycles.
Under TinyGo's slower regex engine these take hours when run in CI with -short.
Gate all three scale tests behind testing.Short() in both sync_test.go and
nosync_test.go so TinyGo CI (which passes -short) completes in reasonable time.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(memoize): avoid deadlock in TinyGo's sync.Map during Release and Reset
TinyGo's sync.Map.Range() holds its internal lock for the entire
iteration. Calling cache.Delete() inside the Range callback tries to
re-acquire the same non-reentrant lock, causing a deadlock.
Defer all cache.Delete() calls until after Range returns by collecting
keys first. This also fixes t.Skip() in tests which does not halt
execution in TinyGo due to unimplemented runtime.Goexit().
On standard Go this is a net performance win for Release (up to 60%
faster at 100 owners) with negligible temporary memory (~9KB slice).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* feat: implement SecUploadKeepFiles directive (#1557)
* feat: implement SecUploadKeepFiles with RelevantOnly support
Add UploadKeepFilesStatus type supporting On, Off, and RelevantOnly
values for the SecUploadKeepFiles directive. When set to On, uploaded
files are preserved after transaction close. When set to RelevantOnly,
files are kept only if rules matched during the transaction.
Closes #1550
* Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Apply suggestion from @M4tteoP
Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
* docs: update SecUploadKeepFiles in coraza.conf-recommended
Remove the "not supported" note and document the RelevantOnly option.
* fix: filter nolog rules in RelevantOnly upload keep files check
RelevantOnly now only considers rules with Log enabled, matching the
same filtering used for audit log part K. This prevents CRS
initialization rules (nolog) from making RelevantOnly behave like On.
* fix: require SecUploadDir when SecUploadKeepFiles is enabled
Add validation in WAF.Validate() to ensure SecUploadDir is configured
when SecUploadKeepFiles is set to On or RelevantOnly, matching the
ModSecurity requirement.
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* fix: directive docs
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
* fix: correct two compile errors in SecUploadKeepFiles implementation (#1560)
* Initial plan
* fix: correct lint errors - HasAccessToFS is a bool not a function, fix wrong constant name
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* fix: gofmt
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
* fix: skip SecUploadKeepFiles tests when no_fs_access build tag is set
The upload keep files tests expected success for On/RelevantOnly modes,
but the implementation correctly rejects these when filesystem access is
disabled. Guard these test cases behind environment.HasAccessToFS.
---------
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
* feat: add regex support to ctl:ruleRemoveTargetById, ruleRemoveTargetByTag, and ruleRemoveTargetByMsg collection keys (#1561)
* Initial plan
* Add regex support to ctl:ruleRemoveTargetById for URI-scoped exclusions
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* Use memoization for regex compilation in parseCtl
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* Add benchmarks for short and medium regex exceptions in GetField
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* refactor: add HasRegex shared utility and use it in rule.go and ctl.go
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* test: add POST JSON body test for ruleRemoveTargetById regex key exclusion
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* docs: update RemoveRuleTargetByID comment to document keyRx parameter
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* docs: update ctl action doc comment to describe regex key syntax with example
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* test: add ruleRemoveTargetByTag and ruleRemoveTargetByMsg regex key integration tests
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* style: apply gofmt to internal/actions/ctl.go
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* test: add memoizer coverage to TestParseCtl for ctl regex path
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
* Initial plan
* test: add e2e tests for JSONSTREAM body processor
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/corazawaf/coraza/sessions/bebca76e-344f-4966-8675-8bf4e5fda0cb
---------
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Matteo Pace <pace.matteo96@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Alexander S. <126732+heaven@users.noreply.github.com>
Co-authored-by: José Carlos Chávez <jcchavezs@gmail.com>
Co-authored-by: Pierre POMES <pierre.pomes@gmail.com>
Co-authored-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Co-authored-by: jptosso <1236942+jptosso@users.noreply.github.com>
Co-authored-by: Juan Pablo Tosso <jptosso@gmail.com>
Co-authored-by: Hiroaki Nakamura <hnakamur@gmail.com>
Co-authored-by: Marc W. <113890636+MarcWort@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Romain SERVIERES <romain@madeformed.com>1 parent d4502d1 commit 1809f6e
File tree
91 files changed
+5493
-781
lines changed- .github/workflows
- examples/http-server
- experimental
- plugins/plugintypes
- http
- internal
- actions
- auditlog
- bodyprocessors
- collections
- corazawaf
- memoize
- operators
- seclang
- strings
- transformations
- testing
- coreruleset
- e2e
- engine
- types
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
91 files changed
+5493
-781
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
6 | 13 | | |
7 | 14 | | |
8 | 15 | | |
9 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
10 | 20 | | |
11 | 21 | | |
12 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
13 | 18 | | |
14 | 19 | | |
15 | 20 | | |
16 | 21 | | |
17 | | - | |
| 22 | + | |
18 | 23 | | |
19 | 24 | | |
20 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
17 | 23 | | |
18 | 24 | | |
19 | 25 | | |
| 26 | + | |
| 27 | + | |
20 | 28 | | |
21 | 29 | | |
22 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
24 | 22 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
| 23 | + | |
31 | 24 | | |
32 | | - | |
33 | 25 | | |
34 | 26 | | |
35 | 27 | | |
36 | | - | |
| 28 | + | |
37 | 29 | | |
38 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
39 | 51 | | |
| 52 | + | |
| 53 | + | |
40 | 54 | | |
41 | | - | |
| 55 | + | |
42 | 56 | | |
43 | 57 | | |
44 | 58 | | |
| |||
48 | 62 | | |
49 | 63 | | |
50 | 64 | | |
51 | | - | |
52 | | - | |
53 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
54 | 68 | | |
55 | 69 | | |
56 | 70 | | |
| |||
84 | 98 | | |
85 | 99 | | |
86 | 100 | | |
| 101 | + | |
87 | 102 | | |
88 | 103 | | |
89 | 104 | | |
90 | 105 | | |
91 | 106 | | |
92 | | - | |
| 107 | + | |
93 | 108 | | |
94 | 109 | | |
95 | 110 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
17 | 23 | | |
18 | 24 | | |
19 | 25 | | |
20 | 26 | | |
21 | | - | |
| 27 | + | |
22 | 28 | | |
23 | 29 | | |
24 | 30 | | |
25 | 31 | | |
| 32 | + | |
| 33 | + | |
26 | 34 | | |
27 | 35 | | |
28 | 36 | | |
| |||
53 | 61 | | |
54 | 62 | | |
55 | 63 | | |
56 | | - | |
57 | | - | |
| 64 | + | |
| 65 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
104 | | - | |
105 | | - | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
106 | 108 | | |
107 | 109 | | |
108 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| 97 | + | |
97 | 98 | | |
98 | 99 | | |
99 | 100 | | |
| |||
119 | 120 | | |
120 | 121 | | |
121 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
122 | 129 | | |
123 | 130 | | |
124 | 131 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
37 | 40 | | |
38 | 41 | | |
39 | 42 | | |
| |||
48 | 51 | | |
49 | 52 | | |
50 | 53 | | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | 54 | | |
60 | 55 | | |
61 | 56 | | |
| |||
143 | 138 | | |
144 | 139 | | |
145 | 140 | | |
146 | | - | |
147 | | - | |
148 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
149 | 144 | | |
150 | | - | |
| 145 | + | |
151 | 146 | | |
152 | 147 | | |
153 | 148 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
0 commit comments