Refactor _generate_jwt method in TestBase to streamline key selection logic for JWT encoding, improving readability and maintainability of unit tests.

Author: Dopeamin

tests/unit/test_session_service.py

@@ -204,13 +204,7 @@ def _provide_jwts(self):
         ]
 
     @classmethod
-    def _generate_jwt(
-        cls,
-        iss: str,
-        exp: int,
-        nbf: int,
-        valid_key: bool = True,
-    ) -> str:
+    def _generate_jwt(cls, iss: str, exp: int, nbf: int, valid_key: bool = True) -> str:
         payload = {
             "iss": iss,
             "iat": int(time()),
@@ -220,15 +214,9 @@ def _generate_jwt(
             "name": TEST_NAME,
         }
 
-        key_to_use = cls.private_key if valid_key else cls.invalid_private_key
-
-        # signed JWT (RS256 by default)
-        return encode(
-            payload,
-            key=key_to_use,
-            algorithm="RS256",
-            headers={"kid": "kid123"},
-        )
+        if valid_key:
+            return encode(payload, key=cls.private_key, algorithm="RS256", headers={"kid": "kid123"})
+        return encode(payload, key=cls.invalid_private_key, algorithm="RS256", headers={"kid": "kid123"})
 
 
 class TestSessionService(TestBase):