Skip to content

Commit a13c64e

Browse files
authored
Reactivate Signal API (#544)
* Reactivate Signal API * Prettier
1 parent 1e6b214 commit a13c64e

File tree

5 files changed

+27
-4
lines changed

5 files changed

+27
-4
lines changed

packages/connect-react/src/components/passkeyList/PasskeyListScreen.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ const PasskeyListScreen = () => {
9898
return handleSituation(PasskeyListSituationCode.CboApiNotAvailableDuringDelete, deletePasskeyRes.val);
9999
}
100100

101-
await getPasskeyList(config);
101+
await getPasskeyList(config, true);
102102
hide();
103103
};
104104

packages/react/changelog.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
- Deactivate WebAuthn Signal API
66

7-
87
## 3.3.0
98

109
### Minor changes

packages/web-core/src/services/WebAuthnService.ts

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,14 +245,36 @@ export class WebAuthnService {
245245

246246
try {
247247
// @ts-ignore
248-
await PublicKeyCredential.signalAllAcceptedCredentials({
248+
const p1 = PublicKeyCredential.signalAllAcceptedCredentials({
249249
rpId: rpId,
250250
userId: userId,
251251
allAcceptedCredentialIds: credentialIds,
252252
});
253+
254+
const p2 = new Promise((_, reject) => setTimeout(() => reject(new Error(`Timeout after 2000ms`)), 2000));
255+
256+
await Promise.race([p1, p2]);
253257
} catch (e) {
254258
log.debug('Error calling signalAllAcceptedCredentials', e);
255259
return;
256260
}
257261
}
262+
263+
static async signalUnknownCredential(rpId: string, credentialId: string): Promise<void> {
264+
// @ts-ignore
265+
if (!window.PublicKeyCredential || !window.PublicKeyCredential.signalUnknownCredential) {
266+
return undefined;
267+
}
268+
269+
try {
270+
// @ts-ignore
271+
await PublicKeyCredential.signalUnknownCredential({
272+
rpId: rpId,
273+
credentialId: credentialId,
274+
});
275+
} catch (e) {
276+
log.debug('Error calling signalUnknownCredential', e);
277+
return;
278+
}
279+
}
258280
}

playground/connect-next/.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,5 @@ yarn-error.log*
3434
# typescript
3535
*.tsbuildinfo
3636
next-env.d.ts
37+
38+
certificates

playground/connect-next/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "0.1.0",
44
"private": true,
55
"scripts": {
6-
"dev": "next dev",
6+
"dev": "next dev --experimental-https",
77
"build": "next build",
88
"start": "next start",
99
"lint": "next lint"

0 commit comments

Comments
 (0)