Skip to content

Commit 14c9f15

Browse files
committed
Refactor code
1 parent bcfcfd0 commit 14c9f15

File tree

6 files changed

+27
-12
lines changed

6 files changed

+27
-12
lines changed

authorizer/session_authorizer.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,10 @@ type SessionAuthorizer struct {
3535

3636
func NewSessionAuthorizer(secretKey string, verifyToken func(tokenString string, secret string) (map[string]interface{}, int64, int64, error),
3737
refreshExpire func(w http.ResponseWriter, sessionId string) error,
38+
cache ICacheService, sessionExpiredTime time.Duration, logError func(ctx context.Context, msg string, opts ...map[string]interface{}), singleSession bool,
3839
encodeSessionID func(sid string) string,
3940
decodeSessionID func(value string) (string, error),
40-
cache ICacheService, sessionExpiredTime time.Duration, logError func(ctx context.Context, msg string, opts ...map[string]interface{}), singleSession bool, opts ...string) *SessionAuthorizer {
41+
opts ...string) *SessionAuthorizer {
4142
var userId, sid, id, prefixSessionIndex, cookieName string
4243
if len(opts) > 0 {
4344
prefixSessionIndex = opts[0]
@@ -195,7 +196,10 @@ func (h *SessionAuthorizer) Verify(next http.Handler, skipRefreshTTL bool, sessi
195196
return
196197
}
197198
if h.RefreshExpire != nil {
198-
err := h.RefreshExpire(writer, h.EncodeSessionID(sessionId))
199+
if h.EncodeSessionID != nil {
200+
sessionId = h.EncodeSessionID(sessionId)
201+
}
202+
err := h.RefreshExpire(writer, sessionId)
199203
if err != nil {
200204
http.Error(writer, "error to refresh expire sessionId", http.StatusInternalServerError)
201205
return

cassandra/user_repository.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@ type UserRepository struct {
4444
func NewUserRepositoryByConfig(session *gocql.Session, userTableName, passwordTableName string, activatedStatus string, status a.UserStatusConfig, c a.SchemaConfig, options ...func(context.Context, string) (bool, error)) *UserRepository {
4545
return NewUserRepository(session, userTableName, passwordTableName, activatedStatus, status, c.Id, c.Username, c.UserId, c.SuccessTime, c.FailTime, c.FailCount, c.LockedUntilTime, c.Status, c.PasswordChangedTime, c.Password, c.Contact, c.Email, c.Phone, c.DisplayName, c.MaxPasswordAge, c.UserType, c.AccessDateFrom, c.AccessDateTo, c.AccessTimeFrom, c.AccessTimeTo, c.TwoFactors, options...)
4646
}
47-
47+
func NewUserAdapterByConfig(session *gocql.Session, userTableName, passwordTableName string, activatedStatus string, status a.UserStatusConfig, c a.SchemaConfig, options ...func(context.Context, string) (bool, error)) *UserRepository {
48+
return NewUserRepositoryByConfig(session, userTableName, passwordTableName, activatedStatus, status, c, options...)
49+
}
4850
func NewUserRepository(session *gocql.Session, userTableName, passwordTableName string, activatedStatus string, status a.UserStatusConfig, idName, userName, userID, successTimeName, failTimeName, failCountName, lockedUntilTimeName, statusName, passwordChangedTimeName, passwordName, contactName, emailName, phoneName, displayNameName, maxPasswordAgeName, userTypeName, accessDateFromName, accessDateToName, accessTimeFromName, accessTimeToName, twoFactorsName string, options ...func(context.Context, string) (bool, error)) *UserRepository {
4951
var checkTwoFactors func(context.Context, string) (bool, error)
5052
if len(options) >= 1 {

dynamodb/user_repository.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,9 @@ type UserRepository struct {
4646
func NewUserRepositoryByConfig(dynamoDB *dynamodb.DynamoDB, userTableName, passwordTableName string, activatedStatus interface{}, status auth.UserStatusConfig, c auth.SchemaConfig, options ...func(context.Context, string) (bool, error)) *UserRepository {
4747
return NewUserRepository(dynamoDB, userTableName, passwordTableName, activatedStatus, status, c.Username, c.SuccessTime, c.FailTime, c.FailCount, c.LockedUntilTime, c.Status, c.PasswordChangedTime, c.Password, c.Contact, c.Email, c.Phone, c.DisplayName, c.MaxPasswordAge, c.Roles, c.UserType, c.AccessDateFrom, c.AccessDateTo, c.AccessTimeFrom, c.AccessTimeTo, c.TwoFactors, options...)
4848
}
49-
49+
func NewUserAdapterByConfig(dynamoDB *dynamodb.DynamoDB, userTableName, passwordTableName string, activatedStatus interface{}, status auth.UserStatusConfig, c auth.SchemaConfig, options ...func(context.Context, string) (bool, error)) *UserRepository {
50+
return NewUserRepositoryByConfig(dynamoDB, userTableName, passwordTableName, activatedStatus, status, c, options...)
51+
}
5052
func NewUserRepository(dynamoDB *dynamodb.DynamoDB, userTableName, passwordTableName string, activatedStatus interface{}, status auth.UserStatusConfig, userName, successTimeName, failTimeName, failCountName, lockedUntilTimeName, statusName, passwordChangedTimeName, passwordName, contactName, emailName, phoneName, displayNameName, maxPasswordAgeName, rolesName, userTypeName, accessDateFromName, accessDateToName, accessTimeFromName, accessTimeToName, twoFactors string, options ...func(context.Context, string) (bool, error)) *UserRepository {
5153
var checkTwoFactors func(context.Context, string) (bool, error)
5254
if len(options) > 0 && options[0] != nil {

mongo/user_repository.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,12 @@ type MongoUserRepository struct {
4545
func NewUserRepositoryByConfig(db *mongo.Database, userCollectionName, passwordCollectionName string, activatedStatus interface{}, status a.UserStatusConfig, c a.SchemaConfig, options ...func(context.Context, string) (bool, error)) *MongoUserRepository {
4646
return NewUserRepository(db, userCollectionName, passwordCollectionName, activatedStatus, status, c.Username, c.SuccessTime, c.FailTime, c.FailCount, c.LockedUntilTime, c.Status, c.PasswordChangedTime, c.Password, c.Contact, c.Email, c.Phone, c.DisplayName, c.MaxPasswordAge, c.Roles, c.UserType, c.AccessDateFrom, c.AccessDateTo, c.AccessTimeFrom, c.AccessTimeTo, c.TwoFactors, options...)
4747
}
48-
48+
func NewUserAdapterByConfig(db *mongo.Database, userCollectionName, passwordCollectionName string, activatedStatus interface{}, status a.UserStatusConfig, c a.SchemaConfig, options ...func(context.Context, string) (bool, error)) *MongoUserRepository {
49+
return NewUserRepositoryByConfig(db, userCollectionName, passwordCollectionName, activatedStatus, status, c, options...)
50+
}
51+
func NewUserAdapter(db *mongo.Database, userCollectionName, passwordCollectionName string, activatedStatus interface{}, status a.UserStatusConfig, userName, successTimeName, failTimeName, failCountName, lockedUntilTimeName, statusName, passwordChangedTimeName, passwordName, contactName, emailName, phoneName, displayNameName, maxPasswordAgeName, rolesName, userTypeName, accessDateFromName, accessDateToName, accessTimeFromName, accessTimeToName, twoFactorsName string, options ...func(context.Context, string) (bool, error)) *MongoUserRepository {
52+
return NewUserRepository(db, userCollectionName, passwordCollectionName, activatedStatus, status, userName, successTimeName, failTimeName, failCountName, lockedUntilTimeName, statusName, passwordChangedTimeName, passwordName, contactName, emailName, phoneName, displayNameName, maxPasswordAgeName, rolesName, userTypeName, accessDateFromName, accessDateToName, accessTimeFromName, accessTimeToName, twoFactorsName, options...)
53+
}
4954
func NewUserRepository(db *mongo.Database, userCollectionName, passwordCollectionName string, activatedStatus interface{}, status a.UserStatusConfig, userName, successTimeName, failTimeName, failCountName, lockedUntilTimeName, statusName, passwordChangedTimeName, passwordName, contactName, emailName, phoneName, displayNameName, maxPasswordAgeName, rolesName, userTypeName, accessDateFromName, accessDateToName, accessTimeFromName, accessTimeToName, twoFactorsName string, options ...func(context.Context, string) (bool, error)) *MongoUserRepository {
5055
passwordCollection := db.Collection(passwordCollectionName)
5156
userCollection := passwordCollection
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"strings"
99
)
1010

11-
type PrivilegesLoader struct {
11+
type PrivilegesAdapter struct {
1212
DB *sql.DB
1313
Query string
1414
ParameterCount int
@@ -19,16 +19,16 @@ type PrivilegesLoader struct {
1919
moduleFields map[string]int
2020
}
2121

22-
func NewPrivilegesLoader(db *sql.DB, query string, options ...int) (*PrivilegesLoader, error) {
22+
func NewPrivilegesAdapter(db *sql.DB, query string, options ...int) (*PrivilegesAdapter, error) {
2323
var parameterCount int
2424
if len(options) >= 1 && options[0] > 0 {
2525
parameterCount = options[0]
2626
} else {
2727
parameterCount = 0
2828
}
29-
return NewSqlPrivilegesLoader(db, query, parameterCount, false, true, true)
29+
return NewSqlPrivilegesAdapter(db, query, parameterCount, false, true, true)
3030
}
31-
func NewSqlPrivilegesLoader(db *sql.DB, query string, parameterCount int, options ...bool) (*PrivilegesLoader, error) {
31+
func NewSqlPrivilegesAdapter(db *sql.DB, query string, parameterCount int, options ...bool) (*PrivilegesAdapter, error) {
3232
var or, handleDriver, noSequence bool
3333
if len(options) >= 1 {
3434
or = options[0]
@@ -55,9 +55,9 @@ func NewSqlPrivilegesLoader(db *sql.DB, query string, parameterCount int, option
5555
if err != nil {
5656
return nil, err
5757
}
58-
return &PrivilegesLoader{DB: db, Query: query, ParameterCount: parameterCount, Or: or, NoSequence: noSequence, HandleDriver: handleDriver, Driver: driver, moduleFields: moduleFields}, nil
58+
return &PrivilegesAdapter{DB: db, Query: query, ParameterCount: parameterCount, Or: or, NoSequence: noSequence, HandleDriver: handleDriver, Driver: driver, moduleFields: moduleFields}, nil
5959
}
60-
func (l PrivilegesLoader) Load(ctx context.Context, id string) ([]auth.Privilege, error) {
60+
func (l PrivilegesAdapter) Load(ctx context.Context, id string) ([]auth.Privilege, error) {
6161
var models []auth.Module
6262
p0 := make([]auth.Privilege, 0)
6363
params := make([]interface{}, 0)

sql/user_repository.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ type SqlUserRepository struct {
2121
Param func(int) string
2222
Conf DBConfig
2323
}
24-
24+
func NewUserAdapter(db *sql.DB, query string, conf DBConfig, status a.UserStatusConfig, options ...bool) (*SqlUserRepository, error) {
25+
return NewUserRepository(db, query, conf, status, options...)
26+
}
2527
func NewUserRepository(db *sql.DB, query string, conf DBConfig, status a.UserStatusConfig, options ...bool) (*SqlUserRepository, error) {
2628
var handleDriver bool
2729
if len(options) >= 1 {

0 commit comments

Comments
 (0)