Skip to content

Commit a4355f4

Browse files
committed
ci/test: handle failures properly
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
1 parent 4e3d002 commit a4355f4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,17 @@ jobs:
4545

4646
- name: Run tests
4747
run: ./waf test
48-
continue-on-error: true
4948

5049
- name: Publish Test Report
5150
uses: mikepenz/action-junit-report@v5
52-
if: success() || failure()
51+
if: (!cancelled())
5352
with:
5453
report_paths: build/test/junit.xml
5554
annotate_only: true
5655

5756
- name: Store failed test images
5857
uses: actions/upload-artifact@v4
58+
if: (!cancelled())
5959
with:
6060
name: failed_diff_images
6161
path: build/test/tests/failed/*-diff.png

0 commit comments

Comments
 (0)