Merge pull request #103 from coregx/feature/findall-multiline-fix

fix: FindAll now uses UseMultilineReverseSuffix strategy (#102)

Author: kolkov

CHANGELOG.md

@@ -14,6 +14,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## [0.11.4] - 2026-01-16
+
+### Fixed
+- **FindAll/FindAllIndex now use UseMultilineReverseSuffix strategy** (Issue #102)
+  - Previously `FindIndicesAt()` was missing dispatch for `UseMultilineReverseSuffix`
+  - `IsMatch`/`Find` were fast (1µs), but `FindAll` was slow (78ms) - **100x gap vs Rust**
+  - After fix: `FindAll` on 6MB with 2000 matches: **~1ms** (was 78ms)
+
+### Changed
+- Updated `golang.org/x/sys` dependency v0.39.0 → v0.40.0
+
+---
+
 ## [0.11.3] - 2026-01-16
 
 ### Changed
@@ -1537,6 +1550,7 @@ v1.0.0 → Stable release (API frozen)
 ---
 
 [Unreleased]: https://github.com/coregx/coregex/compare/v0.11.3...HEAD
+[0.11.4]: https://github.com/coregx/coregex/releases/tag/v0.11.4
 [0.11.3]: https://github.com/coregx/coregex/releases/tag/v0.11.3
 [0.11.2]: https://github.com/coregx/coregex/releases/tag/v0.11.2
 [0.11.1]: https://github.com/coregx/coregex/releases/tag/v0.11.1

go.mod

@@ -4,5 +4,5 @@ go 1.25.4
 
 require (
 	github.com/coregx/ahocorasick v0.1.0
-	golang.org/x/sys v0.39.0
+	golang.org/x/sys v0.40.0
 )

go.sum

@@ -1,4 +1,4 @@
 github.com/coregx/ahocorasick v0.1.0 h1:CiCQwQ/Gu6pahlO3u4jrPo8q0Tb8pLknU7tzqiLRZcw=
 github.com/coregx/ahocorasick v0.1.0/go.mod h1:SDcS9KTiwLP8FHNpYSO3Q3mRqrK8SYJAYpygrhcIils=
-golang.org/x/sys v0.39.0 h1:CvCKL8MeisomCi6qNZ+wbb0DN9E5AATixKsvNtMoMFk=
-golang.org/x/sys v0.39.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
+golang.org/x/sys v0.40.0 h1:DBZZqJ2Rkml6QMQsZywtnjnnGvHza6BTfYFWY9kjEWQ=
+golang.org/x/sys v0.40.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=

meta/find_indices.go

@@ -46,6 +46,8 @@ func (e *Engine) FindIndices(haystack []byte) (start, end int, found bool) {
 		return e.findIndicesDigitPrefilter(haystack)
 	case UseAhoCorasick:
 		return e.findIndicesAhoCorasick(haystack)
+	case UseMultilineReverseSuffix:
+		return e.findIndicesMultilineReverseSuffix(haystack)
 	default:
 		return e.findIndicesNFA(haystack)
 	}
@@ -86,6 +88,8 @@ func (e *Engine) FindIndicesAt(haystack []byte, at int) (start, end int, found b
 		return e.findIndicesDigitPrefilterAt(haystack, at)
 	case UseAhoCorasick:
 		return e.findIndicesAhoCorasickAt(haystack, at)
+	case UseMultilineReverseSuffix:
+		return e.findIndicesMultilineReverseSuffixAt(haystack, at)
 	default:
 		return e.findIndicesNFAAt(haystack, at)
 	}
@@ -436,6 +440,24 @@ func (e *Engine) findIndicesReverseInnerAt(haystack []byte, at int) (int, int, b
 	return e.reverseInnerSearcher.FindIndicesAt(haystack, at)
 }
 
+// findIndicesMultilineReverseSuffix searches using multiline suffix optimization - zero alloc.
+func (e *Engine) findIndicesMultilineReverseSuffix(haystack []byte) (int, int, bool) {
+	if e.multilineReverseSuffixSearcher == nil {
+		return e.findIndicesNFA(haystack)
+	}
+	atomic.AddUint64(&e.stats.DFASearches, 1)
+	return e.multilineReverseSuffixSearcher.FindIndicesAt(haystack, 0)
+}
+
+// findIndicesMultilineReverseSuffixAt searches using multiline suffix optimization from position - zero alloc.
+func (e *Engine) findIndicesMultilineReverseSuffixAt(haystack []byte, at int) (int, int, bool) {
+	if e.multilineReverseSuffixSearcher == nil {
+		return e.findIndicesNFAAt(haystack, at)
+	}
+	atomic.AddUint64(&e.stats.DFASearches, 1)
+	return e.multilineReverseSuffixSearcher.FindIndicesAt(haystack, at)
+}
+
 // findIndicesBoundedBacktracker searches using bounded backtracker - zero alloc.
 // Thread-safe: uses pooled state.
 func (e *Engine) findIndicesBoundedBacktracker(haystack []byte) (int, int, bool) {