Skip to content

Commit 0254b86

Browse files
committed
mantle/kola: increase reboot wait time for fcos.upgrade.basic
We've been seeing this fail a lot more on AWS recently and we think it's because we're bumping up into this timeout. The truth is that we're not just waiting for a reboot here, but actually waiting for zincati to select the upgrade, for rpm-ostree to deploy it, finalize and reboot. Given all that I can see why this might be bumping up into the limit. ``` === RUN fcos.upgrade.basic === RUN fcos.upgrade.basic/setup === RUN fcos.upgrade.basic/upgrade-from-previous === RUN fcos.upgrade.basic/upgrade-from-current --- FAIL: fcos.upgrade.basic (495.26s) --- PASS: fcos.upgrade.basic/setup (204.18s) cluster.go:162: real 0m0.045s cluster.go:162: user 0m0.006s cluster.go:162: sys 0m0.012s --- FAIL: fcos.upgrade.basic/upgrade-from-previous (122.05s) basic.go:347: failed waiting for machine reboot: timed out after 2m0s waiting for machine to reboot --- SKIP: fcos.upgrade.basic/upgrade-from-current (0.00s) cluster.go:54: A previous test has already failed ```
1 parent 93e6e82 commit 0254b86

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mantle/kola/tests/upgrade/basic.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ func runFnAndWaitForRebootIntoVersion(c cluster.TestCluster, m platform.Machine,
343343

344344
fn()
345345

346-
if err := m.WaitForReboot(120*time.Second, oldBootId); err != nil {
346+
if err := m.WaitForReboot(240*time.Second, oldBootId); err != nil {
347347
c.Fatalf("failed waiting for machine reboot: %v", err)
348348
}
349349

0 commit comments

Comments
 (0)