testiso.go: Add check for badness

After tests are complete this checks for badness in the
console.txt and journal.txt files.

Ref: #3788

Co-authored-by: Dusty Mabe <[email protected]>

Author: c4rt0

mantle/cmd/kola/testiso.go

@@ -657,6 +657,8 @@ func runTestIso(cmd *cobra.Command, args []string) (err error) {
 func awaitCompletion(ctx context.Context, inst *platform.QemuInstance, outdir string, qchan *os.File, booterrchan chan error, expected []string) (time.Duration, error) {
 	start := time.Now()
 	errchan := make(chan error)
+	// Retrurns the amount of time it took for the test to run
+	elapsed := time.Since(start)
 	go func() {
 		timeout := (time.Duration(installTimeoutMins*(100+kola.Options.ExtendTimeoutPercent)) * time.Minute) / 100
 		time.Sleep(timeout)
@@ -679,57 +681,100 @@ func awaitCompletion(ctx context.Context, inst *platform.QemuInstance, outdir st
 				errchan <- err
 			}
 		}()
-	}
-	go func() {
-		err := inst.Wait()
-		// only one Wait() gets process data, so also manually check for signal
-		plog.Debugf("qemu exited err=%v", err)
-		if err == nil && inst.Signaled() {
-			err = errors.New("process killed")
-		}
-		if err != nil {
-			errchan <- errors.Wrapf(err, "QEMU unexpectedly exited while awaiting completion")
-		}
-		time.Sleep(1 * time.Minute)
-		errchan <- fmt.Errorf("QEMU exited; timed out waiting for completion")
-	}()
-	go func() {
-		r := bufio.NewReader(qchan)
-		for _, exp := range expected {
-			l, err := r.ReadString('\n')
+		go func() {
+			err := inst.Wait()
+			// only one Wait() gets process data, so also manually check for signal
+			plog.Debugf("qemu exited err=%v", err)
+			if err == nil && inst.Signaled() {
+				err = errors.New("process killed")
+			}
 			if err != nil {
-				if err == io.EOF {
-					// this may be from QEMU getting killed or exiting; wait a bit
-					// to give a chance for .Wait() above to feed the channel with a
-					// better error
-					time.Sleep(1 * time.Second)
-					errchan <- fmt.Errorf("Got EOF from completion channel, %s expected", exp)
-				} else {
-					errchan <- errors.Wrapf(err, "reading from completion channel")
+				errchan <- errors.Wrapf(err, "QEMU unexpectedly exited while awaiting completion")
+			}
+			time.Sleep(1 * time.Minute)
+			errchan <- fmt.Errorf("QEMU exited; timed out waiting for completion")
+		}()
+		go func() {
+			r := bufio.NewReader(qchan)
+			for _, exp := range expected {
+				l, err := r.ReadString('\n')
+				if err != nil {
+					if err == io.EOF {
+						// this may be from QEMU getting killed or exiting; wait a bit
+						// to give a chance for .Wait() above to feed the channel with a
+						// better error
+						time.Sleep(1 * time.Second)
+						errchan <- fmt.Errorf("Got EOF from completion channel, %s expected", exp)
+					} else {
+						errchan <- errors.Wrapf(err, "reading from completion channel")
+					}
+					return
+				}
+				line := strings.TrimSpace(l)
+				if line != exp {
+					errchan <- fmt.Errorf("Unexpected string from completion channel: %s expected: %s", line, exp)
+					return
 				}
-				return
+				plog.Debugf("Matched expected message %s", exp)
 			}
-			line := strings.TrimSpace(l)
-			if line != exp {
-				errchan <- fmt.Errorf("Unexpected string from completion channel: %s expected: %s", line, exp)
-				return
+			plog.Debugf("Matched all expected messages")
+			// OK!
+			errchan <- nil
+		}()
+		go func() {
+			//check for error when switching boot order
+			if booterrchan != nil {
+				if err := <-booterrchan; err != nil {
+					errchan <- err
+				}
 			}
-			plog.Debugf("Matched expected message %s", exp)
-		}
-		plog.Debugf("Matched all expected messages")
-		// OK!
-		errchan <- nil
-	}()
-	go func() {
-		//check for error when switching boot order
-		if booterrchan != nil {
-			if err := <-booterrchan; err != nil {
-				errchan <- err
+		}()
+		err := <-errchan
+		if err == nil {
+			// No error so far, check the console and journal files
+			consoleFile := filepath.Join(outdir, "console.txt")
+			journalFile := filepath.Join(outdir, "journal.txt")
+			files := []string{consoleFile, journalFile}
+			for _, file := range files {
+				fileName := filepath.Base(file)
+				// Check if the file exists
+				_, err := os.Stat(file)
+				if os.IsNotExist(err) {
+					fmt.Printf("The file: %v does not exist\n", fileName)
+					continue
+				} else if err != nil {
+					fmt.Println(err)
+					return elapsed, err
+				}
+				// Read the contents of the file
+				fileContent, err := os.ReadFile(file)
+				if err != nil {
+					fmt.Println(err)
+					return elapsed, err
+				}
+				// Check for badness with CheckConsole
+				warnOnly, badlines := kola.CheckConsole([]byte(fileContent), nil)
+				if len(badlines) > 0 {
+					for _, badline := range badlines {
+						err = fmt.Errorf("badness detected: \n%v", badline)
+						fmt.Printf("badness detected\n")
+						if err != nil {
+							return elapsed, err
+						}
+						if !warnOnly {
+							plog.Errorf("checkConsole found bad lines in %v\n", fileName)
+							return elapsed, err
+						} else {
+							plog.Warningf("WarnOnly: %v\n", warnOnly)
+						}
+					}
+				}
 			}
 		}
-	}()
+		return elapsed, err
+	}
 	err := <-errchan
-	return time.Since(start), err
+	return elapsed, err
 }
 
 func printResult(test string, duration time.Duration, err error) bool {