Skip to content

Commit 7fe8cd4

Browse files
marmijodustymabe
authored andcommitted
kola/azure: correct default vm size
I mistakenly thought that Standard_D2_v3 was compatible with Hyper-V Gen2, but this is incorrect. Instead, let's use Standard_D2s_v3 which does support Gen2. Fixes: 083029f
1 parent 083029f commit 7fe8cd4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

docs/kola.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,8 @@ In order to see the logs for these tests you must enter the `tmp/kola/name_of_th
247247
- `gcp-json-key` is using a service account's JSON key for authentication, how to create service account keys refer to https://github.com/coreos/coreos-assembler/blob/main/docs/mantle/credentials.md#gcp.
248248
- `gcp-project` is meant for testing in the specified project, or it will use the same as `<GCP Image Project>`.
249249

250-
`cosa kola run --arch=x86_64 -p=azure --azure-credentials azureCreds.json --azure-disk-uri ${ImageId} basic` This will run the basic tests on Azure using default machine type `Standard_D2_v3`.
250+
`cosa kola run --arch=x86_64 -p=azure --azure-credentials azureCreds.json --azure-disk-uri ${ImageId} basic` This will run the basic tests on Azure using default machine type `Standard_D2s_v3`.
251251
- `azure-credentials` is a JSON file generated by hand to pass authentication to our mantle code that will then use it to authenticate with azure services, how to create credentials refer to https://github.com/coreos/coreos-assembler/blob/main/docs/mantle/credentials.md#azure
252252
- `azure-disk-uri` is Azure disk uri of the custom image, this could be a gallery image version if you are using Azure Compute Gallery, refer to https://learn.microsoft.com/en-us/azure/virtual-machines/azure-compute-gallery. For example, get gallery image id via command: `galleryImageId=$(az sig image-version show --gallery-image-definition "${gallery_image_definition}" --gallery-image-version "${gallery_image_version}" --gallery-name "${gallery_name}" --resource-group $az_resource_group | jq -r .id)`.
253253
- `azure-location` specifies Azure location if you want to use custom location, by default is `westus`.
254-
- `azure-size` specifies Azure machine size if you want to use custom size, by default is `Standard_D2_v3`.
254+
- `azure-size` specifies Azure machine size if you want to use custom size, by default is `Standard_D2s_v3`.

mantle/cmd/kola/options.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ func init() {
9999
sv(&kola.AzureOptions.Sku, "azure-sku", "alpha", "Azure image sku/channel (default \"alpha\"")
100100
sv(&kola.AzureOptions.Version, "azure-version", "", "Azure image version")
101101
sv(&kola.AzureOptions.Location, "azure-location", "westus", "Azure location (default \"westus\"")
102-
sv(&kola.AzureOptions.Size, "azure-size", "Standard_D2_v3", "Azure machine size (default \"Standard_D2_v3\")")
102+
sv(&kola.AzureOptions.Size, "azure-size", "Standard_D2s_v3", "Azure machine size (default \"Standard_D2s_v3\")")
103103
sv(&kola.AzureOptions.AvailabilityZone, "azure-availability-zone", "1", "Azure Availability Zone (default \"1\")")
104104

105105
// do-specific options

0 commit comments

Comments
 (0)