kola: don't fail iso.* tests when live arifacts don't exist

Author: nikita-dubrovskii

mantle/kola/tests/iso/common.go

@@ -192,6 +192,16 @@ func CheckTestOutput(output *os.File, expected []string) error {
 	return nil
 }
 
+func EnsureLiveArtifactsExist() error {
+	if kola.CosaBuild.Meta.BuildArtifacts.LiveIso == nil || kola.CosaBuild.Meta.BuildArtifacts.LiveKernel == nil {
+		return errors.Errorf("Build %s is missing live artifacts\n", kola.CosaBuild.Meta.Name)
+	}
+	if kola.CosaBuild.Meta.BuildArtifacts.Metal == nil || kola.CosaBuild.Meta.BuildArtifacts.Metal4KNative == nil {
+		return errors.Errorf("Build %s is missing live metal artifacts\n", kola.CosaBuild.Meta.Name)
+	}
+	return nil
+}
+
 func awaitCompletion(c cluster.TestCluster, inst *platform.QemuInstance, console bool, outdir string, qchan *os.File, booterrchan chan error, expected []string) error {
 	ctx := c.Context()
 

mantle/kola/tests/iso/live-as-disk.go

@@ -1,6 +1,7 @@
 package iso
 
 import (
+	"fmt"
 	"path/filepath"
 
 	"github.com/coreos/coreos-assembler/mantle/kola"
@@ -42,6 +43,11 @@ func isoAsDiskUefiSecure(c cluster.TestCluster) {
 }
 
 func isoTestAsDisk(c cluster.TestCluster, opts IsoTestOpts) {
+	if err := EnsureLiveArtifactsExist(); err != nil {
+		fmt.Println(err)
+		return
+	}
+
 	qc, ok := c.Cluster.(*qemu.Cluster)
 	if !ok {
 		c.Fatalf("Unsupported cluster type")

mantle/kola/tests/iso/live-fips.go

@@ -1,6 +1,7 @@
 package iso
 
 import (
+	"fmt"
 	"path/filepath"
 
 	"github.com/coreos/coreos-assembler/mantle/kola"
@@ -39,6 +40,11 @@ ExecStart=grep FIPS etc/crypto-policies/config
 RequiredBy=fips-signal-ok.service`
 
 func testLiveFIPS(c cluster.TestCluster) {
+	if err := EnsureLiveArtifactsExist(); err != nil {
+		fmt.Println(err)
+		return
+	}
+
 	qc, ok := c.Cluster.(*qemu.Cluster)
 	if !ok {
 		c.Fatalf("Unsupported cluster type")

mantle/kola/tests/iso/live-iscsi.go

@@ -89,6 +89,11 @@ var iscsi_butane_config string
 //   - when the system is booted, write a success string to /dev/virtio-ports/testisocompletion
 //   - as this serial device is mapped to the host serial device, the test concludes
 func isoInstalliScsi(c cluster.TestCluster, opts IsoTestOpts) {
+	if err := EnsureLiveArtifactsExist(); err != nil {
+		fmt.Println(err)
+		return
+	}
+
 	qc, ok := c.Cluster.(*qemu.Cluster)
 	if !ok {
 		c.Fatalf("Unsupported cluster type")

mantle/kola/tests/iso/live-iso.go

@@ -224,6 +224,10 @@ const defaultQemuHostIPv4 = "10.0.2.2"
 const liveISOFromRAMKarg = "coreos.liveiso.fromram"
 
 func isoLiveInstall(c cluster.TestCluster, opts IsoTestOpts) {
+	if err := EnsureLiveArtifactsExist(); err != nil {
+		fmt.Println(err)
+		return
+	}
 	if opts.isMiniso && opts.isOffline { // ideally this'd be one enum parameter
 		c.Fatal("Can't run minimal install offline")
 	}

mantle/kola/tests/iso/live-login.go

@@ -1,6 +1,7 @@
 package iso
 
 import (
+	"fmt"
 	"path/filepath"
 
 	"github.com/coreos/coreos-assembler/mantle/kola"
@@ -20,10 +21,10 @@ func init() {
 }
 
 func testLiveLogin(c cluster.TestCluster, enableUefi bool, enableUefiSecure bool) {
-	if kola.CosaBuild.Meta.BuildArtifacts.LiveIso == nil || kola.CosaBuild.Meta.BuildArtifacts.LiveKernel == nil {
-		c.Fatalf("Build %s is missing live artifacts\n", kola.CosaBuild.Meta.Name)
+	if err := EnsureLiveArtifactsExist(); err != nil {
+		fmt.Println(err)
+		return
 	}
-
 	butane := conf.Butane(`
 variant: fcos
 version: 1.1.0`)

mantle/kola/tests/iso/live-pxe.go

@@ -130,6 +130,11 @@ RequiredBy=coreos-installer.target
 `
 
 func testPXE(c cluster.TestCluster, opts IsoTestOpts) {
+	if err := EnsureLiveArtifactsExist(); err != nil {
+		fmt.Println(err)
+		return
+	}
+
 	var outdir string
 	var qc *qemu.Cluster