kola: set SkipStartMachine and drop unused SSH keys for iso.* tests

The iso.* tests use systemd units that report success or failure via
virtio channels and always power off the machine. Because of this, we
do not need to SSH into the instance or check Ignition errors.

Author: nikita-dubrovskii

mantle/kola/tests/iso/live-as-disk.go

@@ -59,11 +59,6 @@ func isoTestAsDisk(c cluster.TestCluster, opts IsoTestOpts) {
 	}
 	config.AddSystemdUnit("live-signal-ok.service", liveSignalOKUnit, conf.Enable)
 	config.AddSystemdUnit("verify-no-efi-boot-entry.service", verifyNoEFIBootEntry, conf.Enable)
-	keys, err := qc.Keys()
-	if err != nil {
-		c.Fatal(err)
-	}
-	config.CopyKeys(keys)
 
 	overrideFW := func(builder *platform.QemuBuilder) error {
 		switch {
@@ -91,8 +86,10 @@ func isoTestAsDisk(c cluster.TestCluster, opts IsoTestOpts) {
 		return builder.AddIso(isopath, "", true)
 	}
 
+	extra := platform.QemuMachineOptions{}
+	extra.SkipStartMachine = true
 	callbacks := qemu.BuilderCallbacks{SetupDisks: setupDisks, OverrideDefaults: overrideFW}
-	_, err = qc.NewMachineWithQemuOptionsAndBuilderCallbacks(config, platform.QemuMachineOptions{}, callbacks)
+	_, err = qc.NewMachineWithQemuOptionsAndBuilderCallbacks(config, extra, callbacks)
 	if err != nil {
 		c.Fatalf("Unable to create test machine: %v", err)
 	}

mantle/kola/tests/iso/live-fips.go

@@ -57,11 +57,6 @@ func testLiveFIPS(c cluster.TestCluster) {
 	config.AddSystemdUnit("fips-verify.service", fipsVerify, conf.Enable)
 	config.AddSystemdUnit("fips-signal-ok.service", liveSignalOKUnit, conf.Enable)
 	config.AddSystemdUnit("fips-emergency-target.service", signalFailureUnit, conf.Enable)
-	keys, err := qc.Keys()
-	if err != nil {
-		c.Fatal(err)
-	}
-	config.CopyKeys(keys)
 
 	overrideFW := func(builder *platform.QemuBuilder) error {
 		builder.Firmware = "uefi"
@@ -88,8 +83,10 @@ func testLiveFIPS(c cluster.TestCluster) {
 		return builder.AddIso(isopath, "", false)
 	}
 
+	extra := platform.QemuMachineOptions{}
+	extra.SkipStartMachine = true
 	callbacks := qemu.BuilderCallbacks{SetupDisks: setupDisks, OverrideDefaults: overrideFW}
-	_, err = qc.NewMachineWithQemuOptionsAndBuilderCallbacks(config, platform.QemuMachineOptions{}, callbacks)
+	_, err = qc.NewMachineWithQemuOptionsAndBuilderCallbacks(config, extra, callbacks)
 	if err != nil {
 		c.Fatalf("Unable to create test machine: %v", err)
 	}

mantle/kola/tests/iso/live-iscsi.go

@@ -113,11 +113,7 @@ func isoInstalliScsi(c cluster.TestCluster, opts IsoTestOpts) {
 	if err != nil {
 		c.Fatal(err)
 	}
-	keys, err := qc.Keys()
-	if err != nil {
-		c.Fatal(err)
-	}
-	config.CopyKeys(keys)
+
 	// Add a failure target to stop the test if something go wrong rather than waiting for the 10min timeout
 	config.AddSystemdUnit("coreos-test-entered-emergency-target.service", signalFailureUnit, conf.Enable)
 	config.MountHost("/var/cosaroot", true)
@@ -179,8 +175,10 @@ func isoInstalliScsi(c cluster.TestCluster, opts IsoTestOpts) {
 		return nil
 	}
 
+	extra := platform.QemuMachineOptions{}
+	extra.SkipStartMachine = true
 	callbacks := qemu.BuilderCallbacks{SetupDisks: setupDisks, OverrideDefaults: overrideFW}
-	_, err = qc.NewMachineWithQemuOptionsAndBuilderCallbacks(config, platform.QemuMachineOptions{}, callbacks)
+	_, err = qc.NewMachineWithQemuOptionsAndBuilderCallbacks(config, extra, callbacks)
 	if err != nil {
 		c.Fatalf("Unable to create test machine: %v", err)
 	}

mantle/kola/tests/iso/live-iso.go

@@ -229,15 +229,11 @@ func isoRunTest(c cluster.TestCluster, opts IsoTestOpts, tempdir string) error {
 	if opts.enableMultipath {
 		qc.EnforceMultipath()
 	}
-	keys, err := qc.Keys()
-	if err != nil {
-		return err
-	}
+
 	targetConfig, err := conf.EmptyIgnition().Render(conf.FailWarnings)
 	if err != nil {
 		return err
 	}
-	targetConfig.CopyKeys(keys)
 	targetConfig.AddSystemdUnit("coreos-test-installer.service", signalCompletionUnit, conf.Enable)
 	targetConfig.AddSystemdUnit("coreos-test-entered-emergency-target.service", signalFailureUnit, conf.Enable)
 	targetConfig.AddSystemdUnit("coreos-test-installer-no-ignition.service", checkNoIgnition, conf.Enable)
@@ -359,7 +355,6 @@ func isoRunTest(c cluster.TestCluster, opts IsoTestOpts, tempdir string) error {
 	if err != nil {
 		return err
 	}
-	liveConfig.CopyKeys(keys)
 	liveConfig.AddSystemdUnit("live-signal-ok.service", liveSignalOKUnit, conf.Enable)
 	liveConfig.AddSystemdUnit("verify-no-efi-boot-entry.service", verifyNoEFIBootEntry, conf.Enable)
 	liveConfig.AddSystemdUnit("iso-not-mounted-when-fromram.service", isoNotMountedUnit, conf.Enable)
@@ -446,8 +441,8 @@ func isoRunTest(c cluster.TestCluster, opts IsoTestOpts, tempdir string) error {
 
 	extra := platform.QemuMachineOptions{}
 	extra.SkipStartMachine = true
-	callacks := qemu.BuilderCallbacks{SetupDisks: setupDisks, SetupNetwork: setupNet, OverrideDefaults: overrideFW}
-	qm, err := qc.NewMachineWithQemuOptionsAndBuilderCallbacks(liveConfig, extra, callacks)
+	callbacks := qemu.BuilderCallbacks{SetupDisks: setupDisks, SetupNetwork: setupNet, OverrideDefaults: overrideFW}
+	qm, err := qc.NewMachineWithQemuOptionsAndBuilderCallbacks(liveConfig, extra, callbacks)
 	if err != nil {
 		return errors.Wrap(err, "unable to create test machine")
 	}

mantle/kola/tests/iso/live-pxe.go

@@ -160,10 +160,7 @@ func testPXE(c cluster.TestCluster, opts IsoTestOpts) {
 		AppendKargs: renderCosaTestIsoDebugKargs(),
 		Insecure:    opts.instInsecure,
 	}
-	keys, err := qc.Keys()
-	if err != nil {
-		c.Fatal(err)
-	}
+
 	installerConfigData, err := yaml.Marshal(installerConfig)
 	if err != nil {
 		c.Fatal(err)
@@ -174,7 +171,6 @@ func testPXE(c cluster.TestCluster, opts IsoTestOpts) {
 	if err != nil {
 		c.Fatal(err)
 	}
-	liveConfig.CopyKeys(keys)
 	liveConfig.AddSystemdUnit("live-signal-ok.service", liveSignalOKUnit, conf.Enable)
 	liveConfig.AddSystemdUnit("coreos-test-entered-emergency-target.service", signalFailureUnit, conf.Enable)
 	if opts.isOffline {
@@ -192,7 +188,6 @@ func testPXE(c cluster.TestCluster, opts IsoTestOpts) {
 	if err != nil {
 		c.Fatal(err)
 	}
-	targetConfig.CopyKeys(keys)
 	targetConfig.AddSystemdUnit("coreos-test-installer.service", signalCompletionUnit, conf.Enable)
 	targetConfig.AddSystemdUnit("coreos-test-entered-emergency-target.service", signalFailureUnit, conf.Enable)
 	targetConfig.AddSystemdUnit("coreos-test-installer-no-ignition.service", checkNoIgnition, conf.Enable)