plume/release: simplify compare static release info

prestist · dustymabe · commit b3efd5bf2ed0 · 2025-09-26T14:16:50.000-04:00
fixes:
S1008: should use 'return a.Version == b.Version' instead of 'if a.Version != b.Version { return false }; return true' (gosimple)
diff --git a/mantle/cmd/plume/release.go b/mantle/cmd/plume/release.go
@@ -371,10 +371,7 @@ func modifyReleaseMetadataIndex(api *aws.API, rel release.Release) {
 }
 
 func compareStaticReleaseInfo(a, b release.IndexRelease) bool {
-	if a.Version != b.Version {
-		return false
-	}
-	return true
+	return a.Version == b.Version
 }
 
 // returns -1 if a is a subset of b, 0 if equal, 1 if a is not a subset of b

Original file line number	Diff line number	Diff line change
`@@ -371,10 +371,7 @@ func modifyReleaseMetadataIndex(api *aws.API, rel release.Release) {`
`371`	`371`	`}`
`372`	`372`
`373`	`373`	`func compareStaticReleaseInfo(a, b release.IndexRelease) bool {`
`374`		`- if a.Version != b.Version {`
`375`		`- return false`
`376`		`- }`
`377`		`- return true`
	`374`	`+ return a.Version == b.Version`
`378`	`375`	`}`
`379`	`376`
`380`	`377`	`// returns -1 if a is a subset of b, 0 if equal, 1 if a is not a subset of b`