plume/release: simplify compare static release info

prestist · prestist · commit b831a5e86be4 · 2025-09-26T10:10:05.000-04:00
Update how we evaluate the conditional to satisfy linter.

'S1008: should use 'return a.Version == b.Version' instead of 'if a.Version != b.Version { return false }; return true' (gosimple)'
diff --git a/mantle/cmd/plume/release.go b/mantle/cmd/plume/release.go
@@ -369,10 +369,7 @@ func modifyReleaseMetadataIndex(api *aws.API, rel release.Release) {
 }
 
 func compareStaticReleaseInfo(a, b release.IndexRelease) bool {
-	if a.Version != b.Version || a.MetadataURL != b.MetadataURL {
-		return false
-	}
-	return true
+	return a.Version == b.Version && a.MetadataURL == b.MetadataURL
 }
 
 // returns -1 if a is a subset of b, 0 if equal, 1 if a is not a subset of b

Original file line number	Diff line number	Diff line change
`@@ -369,10 +369,7 @@ func modifyReleaseMetadataIndex(api *aws.API, rel release.Release) {`
`369`	`369`	`}`
`370`	`370`
`371`	`371`	`func compareStaticReleaseInfo(a, b release.IndexRelease) bool {`
`372`		`- if a.Version != b.Version \|\| a.MetadataURL != b.MetadataURL {`
`373`		`- return false`
`374`		`- }`
`375`		`- return true`
	`372`	`+ return a.Version == b.Version && a.MetadataURL == b.MetadataURL`
`376`	`373`	`}`
`377`	`374`
`378`	`375`	`// returns -1 if a is a subset of b, 0 if equal, 1 if a is not a subset of b`