Revert "Fix CI E1101 error"

dustymabe · dustymabe · commit d085c031b1e6 · 2025-12-02T10:51:28.000-05:00
This reverts commit 4484b11. This is causing an infinite loop (and thus a memory leak), which means our pods get OOM killed when making signing requests.
diff --git a/src/cosalib/fedora_messaging_request.py b/src/cosalib/fedora_messaging_request.py
@@ -194,8 +194,7 @@ def error_cb(failure):
         }
     }
 
-    for d in twisted_consume(callback, bindings=bindings, queues=queues):
-        d.addCallback(registered_cb)
-        d.addErrback(error_cb)  # pylint: disable=E1101
-
+    consumers = twisted_consume(callback, bindings=bindings, queues=queues)
+    consumers.addCallback(registered_cb)
+    consumers.addErrback(error_cb)  # pylint: disable=E1101
     reactor.run(installSignalHandlers=False)  # pylint: disable=E1101

Original file line number	Diff line number	Diff line change
`@@ -194,8 +194,7 @@ def error_cb(failure):`
`194`	`194`	`}`
`195`	`195`	`}`
`196`	`196`
`197`		`- for d in twisted_consume(callback, bindings=bindings, queues=queues):`
`198`		`- d.addCallback(registered_cb)`
`199`		`- d.addErrback(error_cb) # pylint: disable=E1101`
`200`		`-`
	`197`	`+ consumers = twisted_consume(callback, bindings=bindings, queues=queues)`
	`198`	`+ consumers.addCallback(registered_cb)`
	`199`	`+ consumers.addErrback(error_cb) # pylint: disable=E1101`
`201`	`200`	`reactor.run(installSignalHandlers=False) # pylint: disable=E1101`