mantle/podman.go: use RetryUntilTimeout in podman.workflow
#3994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The podman.workflow test has been failing on OpenStack, likely because pulling the Fedora container takes too long. Use the `RetryUntilTimeout` function to retry every minute for up to 15 minutes to allow sufficient time to pull the Fedora container. In local testing, pulling the container on OpenStack took approximately 5 minutes before succeeding. See: coreos/fedora-coreos-tracker#1835
gursewak1997
approved these changes
Dec 17, 2024
Member
|
/test rhcos |
Member
Author
|
/retest |
dustymabe
reviewed
Dec 18, 2024
| } | ||
|
|
||
| if err := util.Retry(6, 10*time.Second, podIsRunning); err != nil { | ||
| if err := util.RetryUntilTimeout(15*time.Minute, 5*time.Minute, podIsRunning); err != nil { |
Member
There was a problem hiding this comment.
does this mean it will only try every 5 minutes? I think checking more frequently (like 30s or 1m) would be more ideal.
Previously it was only trying 6 times at an interval of 10s (i.e. 1 minute until timeout/failure). Now if it fails the first time we are waiting 5 minutes for this test to try again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The podman.workflow test has been failing on OpenStack, likely because pulling the Fedora container takes too long. Use the
RetryUntilTimeoutfunction to retry every minute for up to 15 minutes to allow sufficient time to pull the Fedora container. In local testing, pulling the container on OpenStack took approximately 5 minutes before succeeding.See: coreos/fedora-coreos-tracker#1835