Expand openstack's GC to volumes

[gursewak1997]

Expand OpenStack's GC to volumes and get all the relevant packages

[dustymabe]

// Skip volumes that are in use or not in an "available" state
if volume.Status != "available" || volume.CreatedAt.After(threshold) {
	continue
}

I think this is the tricky part. There are two things here:

1. It would be really really nice if those volumes somehow had some metadata we could check (like the createdby:mantle checks we do elsewhere) so we're not just blasting all volumes in an account. Do you know if any metadata like that exists?
2. We might have to expand our volume.Status over time to include more as IIRC some of the volumes aren't available but in some other state like error or provisioning and they just get stuck there. Not sure if there is anything we can actually do for those states or not, though.

[gursewak1997]

1. It would be really really nice if those volumes somehow had some metadata we could check (like the createdby:mantle checks we do elsewhere) so we're not just blasting all volumes in an account. Do you know if any metadata like that exists?

We have 'image_name': 'kola-*' that we can use.
if strings.HasPrefix(volume.Name, "kola-") {

2. We might have to expand our volume.Status over time to include more as IIRC some of the volumes aren't available but in some other state like error or provisioning and they just get stuck there. Not sure if there is anything we can actually do for those states or not, though.

We can extend it to additionally delete all volumes in status starting with 'error*'; possible options are error, error_deleting, error_restoring, error_extending, error_managing, error_migrating, error_attaching, error_detaching, error_replicating

[dustymabe]

Sounds good to me

[dustymabe]

/lgtm