cmd-import: proxy org.opencontainers.image.title to summary in meta.json #4291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used by some code in this codebase. Notably some cloud uploads and e.g. our OVAs. Closes: coreos/fedora-coreos-tracker#2017
|
Skipping CI for Draft Pull Request. |
…onfig-git The field is optional in the schema and it's not populated in the buildah path. Just assume it's not dirty if it's missing.
dustymabe
reviewed
Aug 29, 2025
| 'commit': commit, | ||
| } | ||
|
|
||
| summary = metadata.get('Labels', {}).get('org.opencontainers.image.title') |
Member
There was a problem hiding this comment.
since we populate description too I think it seems more obvious if we were to use that here instead of title.
Suggested change
| summary = metadata.get('Labels', {}).get('org.opencontainers.image.title') | |
| summary = metadata.get('Labels', {}).get('org.opencontainers.image.description') |
optional, of course.
travier
approved these changes
Aug 29, 2025
Member
travier
left a comment
travier
left a comment
There was a problem hiding this comment.
I like description as well. Can be a followup PR.
Member
|
CI failing on #4254 but otherwise looks OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used by some code in this codebase. Notably some cloud uploads and e.g. our OVAs.
Closes: coreos/fedora-coreos-tracker#2017