deps: add yq #4295
Merged
deps: add yq #4295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds yq as a dependency. The change itself is simple, but the justification provided in the pull request description could cause confusion. It states yq is for manipulating JSON files, but jq is already a dependency and is the standard tool for this purpose. To improve clarity and maintainability, I've suggested adding a comment to the code to explain the specific reason for adding yq.
We need that tool to manipulate JOSN and YAML files in a convenient way in a Tekton task, see [1]. [1] https://gitlab.com/fedora/bootc/tekton-catalog/-/merge_requests/8
joelcapitao
force-pushed
the
add_yq_dep
branch
from
d251b1d to
187433f
Compare
travier
approved these changes
Sep 3, 2025
Member
Author
|
golanci-linit job failing on #4254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need that tool to manipulate JSON and YAML files in a convenient way in a Tekton task, see [1].
[1] https://gitlab.com/fedora/bootc/tekton-catalog/-/merge_requests/8