cosalib/aws: don't require build artifact for AWS WinLI builds #4315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the build artifact check to support AWS Windows License Included (WinLI) builds, which are created from an existing snapshot and do not require a build artifact. The changes correctly move the artifact check from a generic wrapper to individual cloud provider implementations, with a special exception for AWS WinLI. The AWS ore command is also updated to not require a file when a source snapshot is used. The implementation is solid, with just one minor suggestion to improve a command-line error message for better user experience.
The build artifact is not needed in the AWS WIndows License Included (WinLI) case because the image is built from an existing snapshot. To allow individual cloud providers to override this requirement, move the build artifact check to each provider's wrapper. Don't perform the check in the AWS wrapper if building a winli image. Also modify the AWS ore upload code to not require an upload file when a source snapshot is used, which allows the WinLI image to be built without the need for an upload file.
marmijo
force-pushed
the
winli-build-artifact
branch
from
3f9942d to
641aa63
Compare
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
Sep 10, 2025
The AWS ore wrapper relies on information from image.json. Buildfetch the ostree artifact before creating and replicating the AWS Windows License Included (winli) image to be consistent and use the same values as the original AMI. Also, remove the hack to get around buildfetch'ing the vmdk image since the build artifact is no longer required in the winli build case. See: coreos/coreos-assembler#4315
Member
Author
|
|
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
Sep 16, 2025
The AWS ore wrapper relies on information from image.json. Buildfetch the ostree artifact before creating and replicating the AWS Windows License Included (winli) image to be consistent and use the same values as the original AMI. Also, remove the hack to get around buildfetch'ing the vmdk image since the build artifact is no longer required in the winli build case. See: coreos/coreos-assembler#4315
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
Sep 16, 2025
The AWS ore wrapper relies on information from image.json. Buildfetch the ostree artifact before creating and replicating the AWS Windows License Included (winli) image to be consistent and use the same values as the original AMI. Also, remove the hack in libcloud.groovy to get around buildfetch'ing the vmdk image since the build artifact is no longer required in the winli build case. See: coreos/coreos-assembler#4315
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
Sep 16, 2025
The AWS ore wrapper relies on information from image.json. Buildfetch the ostree artifact before creating and replicating the AWS Windows License Included (winli) image to be consistent and use the same values as the original AMI. Also, remove the hack in libcloud.groovy to get around buildfetch'ing the vmdk image since the build artifact is no longer required in the winli build case. See: coreos/coreos-assembler#4315
marmijo
added a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Sep 19, 2025
The AWS ore wrapper relies on information from image.json. Buildfetch the ostree artifact before creating and replicating the AWS Windows License Included (winli) image to be consistent and use the same values as the original AMI. Also, remove the hack in libcloud.groovy to get around buildfetch'ing the vmdk image since the build artifact is no longer required in the winli build case. See: coreos/coreos-assembler#4315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build artifact is not needed in the AWS WIndows License Included (WinLI) case because the image is built from an existing snapshot. To allow individual cloud providers to override this requirement, move the build artifact check to each provider's wrapper. Don't perform the check in the AWS wrapper if building a winli image.
Also modify the AWS ore upload code to not require an upload file when a source snapshot is used, which allows the WinLI image to be built without the need for an upload file.