cmd-build-with-buildah: add change detection #4323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces change detection to skip re-importing builds if the inputs haven't changed, which is a great optimization. However, I've identified two high-severity issues with the current implementation. One can cause the script to fail in a clean environment where no previous builds exist. The other involves faulty comparison logic that could lead to incorrectly skipping a build import. I've provided code suggestions to address both of these problems.
jlebon
force-pushed
the
pr/no-op-inputhash
branch
from
21fd215 to
a4080a2
Compare
Use the new inputhash label to tell if there was a meaningful change since the previous build. If not, just no-op. Unless `--force` is passed. See also: coreos/fedora-coreos-config#3758
jlebon
force-pushed
the
pr/no-op-inputhash
branch
from
a4080a2 to
407a23c
Compare
dustymabe
reviewed
Sep 16, 2025
Comment on lines
+215
to
+224
| if [ -z "$FORCE" ]; then | ||
| skip_import=1 | ||
| else | ||
| echo "Importing new build anyway (--force)" | ||
| fi | ||
| fi | ||
|
|
||
| if [ -z "${skip_import:-}" ]; then | ||
| /usr/lib/coreos-assembler/cmd-import "${final_ref}" ${SKIP_PRUNE:+--skip-prune} | ||
| fi |
Member
There was a problem hiding this comment.
Could this be written more succinctly?
if [ -n "$FORCE" ]; then
echo "Importing new build anyway (--force)"
/usr/lib/coreos-assembler/cmd-import "${final_ref}" ${SKIP_PRUNE:+--skip-prune}
fi
fi
Member
Author
There was a problem hiding this comment.
We still need to import if hashes don't match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new inputhash label to tell if there was a meaningful change since the previous build. If not, just no-op. Unless
--forceis passed.See also: coreos/fedora-coreos-config#3758