build.sh: freeze rpm-ostree on 2025.10-2.fc42 #4326
Conversation
Otherwise, we'll get the new substitution rules in stable/testing, which will cause mislabeling of `/usr/etc/systemd/system` due to a bug in libselinux v3.8. This is basically the equivalent of coreos/fedora-coreos-config@fb167ed for the legacy path. See also coreos/fedora-coreos-tracker#2030.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request freezes the rpm-ostree package to a specific version to work around an issue with libselinux. The change is clear and the reasoning is well-documented in the code comments and pull request description. My review includes a suggestion to improve the robustness of the shell script for better maintainability.
|
|
||
| # Freeze rpm-ostree on v2025.10 until we have new enough libselinux. See | ||
| # https://github.com/coreos/fedora-coreos-tracker/issues/2030. | ||
| frozendeps=$(echo rpm-ostree-{,libs-}2025.10-2.fc42) |
There was a problem hiding this comment.
While using echo with command substitution to capture the output of brace expansion works here, it's not the most robust pattern in shell scripting. The behavior of echo can be inconsistent across different shells, and it can misinterpret strings that start with a hyphen as options. A safer and more idiomatic approach in bash is to use an array to hold the list of packages, and then join them into a string.
| frozendeps=$(echo rpm-ostree-{,libs-}2025.10-2.fc42) | |
| local temp_pkgs=(rpm-ostree-{,libs-}2025.10-2.fc42) | |
| frozendeps="${temp_pkgs[*]}" |
|
Also surfaced this to Bodhi: https://bodhi.fedoraproject.org/updates/FEDORA-2025-38be2fd733#comment-4307019. |
2 participants
Otherwise, we'll get the new substitution rules in stable/testing, which will cause mislabeling of
/usr/etc/systemd/systemdue to a bug in libselinux v3.8.This is basically the equivalent of
coreos/fedora-coreos-config@fb167ed for the legacy path.
See also coreos/fedora-coreos-tracker#2030.