mantle/kola: check console log for error even in timeout #4371
Conversation
We don't need the message about creating the filesystem to show up in our kola logs.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to improve test reliability by checking console logs for expected errors even in timeout scenarios, which is a good approach for handling race conditions. The refactoring of the console checking logic into a helper function is a positive change for code clarity and reuse. However, I've identified a critical bug in the new timeout handling logic where the original search pattern is incorrectly overwritten, leading to the wrong error message being checked. I've provided a code suggestion to correct this. The other changes, such as reducing a timeout and cleaning up command execution, are reasonable.
There is a race condition that occurs for /dev/virtio-ports/com.coreos.ignition.journal and it's hard to track down. In this case we are just detecting a failure anyway. If we can find the original search failure term after the timeout happens let's consider that success too. See coreos/fedora-coreos-tracker#2019 for more context.
All of these tests run within 15 seconds today. Let's drop the timeout to one minute, which will enable to detect failures quicker and also allow us to fallback to the new "best effort" console check in the timeout path quicker.
dustymabe
force-pushed
the
dusty-kola-failure-try-again
branch
from
dbb32ac to
7ab7057
Compare
prestist
left a comment
prestist
left a comment
There was a problem hiding this comment.
These changes make sense to me LGTM!
|
/retest |
We've decided to just work around the race condition in coreos/coreos-assembler#4371 so we shouldn't see this failure any longer. Closes coreos/fedora-coreos-tracker#2019
We've decided to just work around the race condition in coreos/coreos-assembler#4371 so we shouldn't see this failure any longer. Closes coreos/fedora-coreos-tracker#2019
2 participants
There is a race condition that occurs for
/dev/virtio-ports/com.coreos.ignition.journal and it's hard to
track down. In this case we are just detecting a failure anyway.
If we can find the original search failure term after the timeout
happens let's consider that success too.
See coreos/fedora-coreos-tracker#2019
for more context.