From d085c031b1e6c8c808e7f226c606eecc7b32254e Mon Sep 17 00:00:00 2001 From: Dusty Mabe Date: Tue, 2 Dec 2025 10:51:28 -0500 Subject: [PATCH 1/2] Revert "Fix CI E1101 error" This reverts commit 4484b11c2a6460253bd342bb845c032fb957e7c0. This is causing an infinite loop (and thus a memory leak), which means our pods get OOM killed when making signing requests. --- src/cosalib/fedora_messaging_request.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/cosalib/fedora_messaging_request.py b/src/cosalib/fedora_messaging_request.py index 608bcd9cb0..9ff9741e78 100644 --- a/src/cosalib/fedora_messaging_request.py +++ b/src/cosalib/fedora_messaging_request.py @@ -194,8 +194,7 @@ def error_cb(failure): } } - for d in twisted_consume(callback, bindings=bindings, queues=queues): - d.addCallback(registered_cb) - d.addErrback(error_cb) # pylint: disable=E1101 - + consumers = twisted_consume(callback, bindings=bindings, queues=queues) + consumers.addCallback(registered_cb) + consumers.addErrback(error_cb) # pylint: disable=E1101 reactor.run(installSignalHandlers=False) # pylint: disable=E1101 From 0e773f1efb2f534cc8fbca7e369299e1d4c0efce Mon Sep 17 00:00:00 2001 From: Dusty Mabe Date: Tue, 2 Dec 2025 12:49:38 -0500 Subject: [PATCH 2/2] fedora_messaging_request: pylint disable=E1101 on addCallback Similar to what we were already doing for addErrback. --- src/cosalib/fedora_messaging_request.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cosalib/fedora_messaging_request.py b/src/cosalib/fedora_messaging_request.py index 9ff9741e78..afb2c67808 100644 --- a/src/cosalib/fedora_messaging_request.py +++ b/src/cosalib/fedora_messaging_request.py @@ -195,6 +195,6 @@ def error_cb(failure): } consumers = twisted_consume(callback, bindings=bindings, queues=queues) - consumers.addCallback(registered_cb) + consumers.addCallback(registered_cb) # pylint: disable=E1101 consumers.addErrback(error_cb) # pylint: disable=E1101 reactor.run(installSignalHandlers=False) # pylint: disable=E1101