Skip to content

Commit 2e993b4

Browse files
committed
jobs/build: don't make uploading global
This variable doesn't need to be global.
1 parent 582bfae commit 2e993b4

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

jobs/build-arch.Jenkinsfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import org.yaml.snakeyaml.Yaml;
22

3-
def pipeutils, pipecfg, uploading, libcloud
3+
def pipeutils, pipecfg, libcloud
44
node {
55
checkout scm
66
pipeutils = load("utils.groovy")
@@ -122,10 +122,9 @@ lock(resource: "build-${params.STREAM}-${basearch}") {
122122

123123
// Now, determine if we should do any uploads to remote s3 buckets or clouds
124124
// Don't upload if the user told us not to or we're debugging with KOLA_RUN_SLEEP
125+
def uploading = false
125126
if (s3_stream_dir && (!params.NO_UPLOAD || params.KOLA_RUN_SLEEP)) {
126127
uploading = true
127-
} else {
128-
uploading = false
129128
}
130129

131130
// Wrap a bunch of commands now inside the context of a remote

jobs/build.Jenkinsfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import org.yaml.snakeyaml.Yaml;
22

3-
def pipeutils, pipecfg, uploading, libcloud
3+
def pipeutils, pipecfg, libcloud
44
node {
55
checkout scm
66
pipeutils = load("utils.groovy")
@@ -126,10 +126,9 @@ lock(resource: "build-${params.STREAM}") {
126126

127127
// Now, determine if we should do any uploads to remote s3 buckets or clouds
128128
// Don't upload if the user told us not to or we're debugging with KOLA_RUN_SLEEP
129+
def uploading = false
129130
if (s3_stream_dir && (!params.NO_UPLOAD || params.KOLA_RUN_SLEEP)) {
130131
uploading = true
131-
} else {
132-
uploading = false
133132
}
134133

135134
// add any additional root CA cert before we do anything that fetches

0 commit comments

Comments
 (0)