ci: fix running tests in containers

Ubuntu-20.04 is no longer supported by GHA CI, and when switching to
ubuntu-latest (which is 24.04 at the moment), tests built on the host
no longer work inside a container, because they require newer glibc:

	Running tests...
	/opt/src/github.com/coreos/go-systemd/test_bins /opt/src/github.com/coreos/go-systemd
	  - activation
	./activation.test: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ./activation.test)
	./activation.test: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by ./activation.test)

So, let's switch to building tests inside the container as well.

Note:
 - the default Go version that comes with a distro is used for building;
 - there is no need to build sources.

Signed-off-by: Kir Kolyshkin <[email protected]>

Author: kolyshkin

.github/workflows/containers.yml

@@ -10,43 +10,34 @@ on:
 permissions:
   contents: read
 
-env:
-  GO_TOOLCHAIN: "1.24"
-  GOPATH: "/opt"
-  BUILD_DIR: "/opt/src/github.com/coreos/go-systemd"
-
 jobs:
   distro-test:
     name: "Distro test"
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         baseimage: ['debian:bullseye', 'ubuntu:20.04', 'ubuntu:22.04']
     steps:
-      - run: sudo apt-get -qq update
-      - name: Install libsystemd-dev
-        run: sudo apt-get install libsystemd-dev
       - uses: actions/checkout@v4
-      - name: Setup go
-        uses: actions/setup-go@v5
-        with:
-          go-version: ${{ env['GO_TOOLCHAIN'] }}
-      - name: Go build (source)
-        run: ./scripts/ci-runner.sh build_source
-      - name: Go build (tests)
-        run: ./scripts/ci-runner.sh build_tests
       - name: Pull base image - ${{ matrix.baseimage }}
         run: docker pull ${{ matrix.baseimage }}
       - name: Install packages for ${{ matrix.baseimage }}
-        run: docker run --privileged -e GOPATH=${GOPATH} --cidfile=/tmp/cidfile ${{ matrix.baseimage }} /bin/bash -c "export DEBIAN_FRONTEND=noninteractive; apt-get update && apt-get install -y sudo build-essential git golang dbus libsystemd-dev libpam-systemd systemd-container"
+        run: docker run --privileged --cidfile=/tmp/cidfile ${{ matrix.baseimage }} /bin/bash -e -c "export DEBIAN_FRONTEND=noninteractive; apt-get update; apt-get install -y sudo build-essential git golang dbus libsystemd-dev libpam-systemd systemd-container"
       - name: Persist base container
-        run: docker commit `cat /tmp/cidfile` go-systemd/container-tests
-      - run: rm -f /tmp/cidfile
+        run: |
+          docker commit `cat /tmp/cidfile` go-systemd/container-tests
+          docker rm -f `cat /tmp/cidfile`
+          rm -f /tmp/cidfile
       - name: Run systemd from ${{ matrix.baseimage }}
-        run: docker run --shm-size=2gb -d --cidfile=/tmp/cidfile --privileged -e GOPATH=${GOPATH} -v ${PWD}:${BUILD_DIR} go-systemd/container-tests /bin/systemd --system
+        run: docker run --shm-size=2gb -d --cidfile=/tmp/cidfile --privileged -v ${PWD}:/src go-systemd/container-tests /bin/systemd --system
+      - name: Fixup git
+        run: docker exec --privileged `cat /tmp/cidfile` /bin/bash -e -c 'git config --global --add safe.directory /src'
+      - name: Build tests
+        run: docker exec --privileged `cat /tmp/cidfile` /bin/bash -e -c 'cd /src; ./scripts/ci-runner.sh build_tests'
       - name: Wait a bit for the whole system to settle
         run: sleep 30s
       - name: Run tests
-        run: docker exec --privileged `cat /tmp/cidfile` /bin/bash -c "cd ${BUILD_DIR} && ./scripts/ci-runner.sh run_tests"
+        run: docker exec --privileged `cat /tmp/cidfile` /bin/bash -e -c 'cd /src; ./scripts/ci-runner.sh run_tests'
       - name: Cleanup
         run: docker kill `cat /tmp/cidfile`