Skip to content

Commit 95af4d3

Browse files
committed
Fixed shadowing of err in sdjournal/read.go
1 parent 54f92f7 commit 95af4d3

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

sdjournal/read.go

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,10 @@ func NewJournalReader(config JournalReaderConfig) (*JournalReader, error) {
131131
// don't fit in the read buffer. Callers should keep calling until 0 and/or an
132132
// error is returned.
133133
func (r *JournalReader) Read(b []byte) (int, error) {
134-
var err error
135-
136134
if r.msgReader == nil {
137-
var c uint64
138-
139135
// Advance the journal cursor. It has to be called at least one time
140136
// before reading
141-
c, err = r.journal.Next()
137+
c, err := r.journal.Next()
142138

143139
// An unexpected error
144140
if err != nil {
@@ -156,18 +152,15 @@ func (r *JournalReader) Read(b []byte) (int, error) {
156152
}
157153

158154
// Build a message
159-
var msg string
160-
msg, err = r.formatter(entry)
161-
155+
msg, err := r.formatter(entry)
162156
if err != nil {
163157
return 0, err
164158
}
165159
r.msgReader = strings.NewReader(msg)
166160
}
167161

168162
// Copy and return the message
169-
var sz int
170-
sz, err = r.msgReader.Read(b)
163+
sz, err := r.msgReader.Read(b)
171164
if err == io.EOF {
172165
// The current entry has been fully read. Don't propagate this
173166
// EOF, so the next entry can be read at the next Read()

0 commit comments

Comments
 (0)