Close the tempfile when journaling large messages

nalind · nalind · commit ff118ad0f8d9 · 2016-01-27T11:08:46.000-05:00
When we fail to log a message to journald due to ENOBUFS or EMSGSIZE, we
attempt to pass the message to journald by passing it a descriptor
attached to some shared memory.  We need to close the descriptor, too.
diff --git a/journal/journal.go b/journal/journal.go
@@ -90,6 +90,7 @@ func Send(message string, priority Priority, vars map[string]string) error {
 		if err != nil {
 			return journalError(err.Error())
 		}
+		defer file.Close()
 		_, err = io.Copy(file, data)
 		if err != nil {
 			return journalError(err.Error())

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ func Send(message string, priority Priority, vars map[string]string) error {`
`90`	`90`	`if err != nil {`
`91`	`91`	`return journalError(err.Error())`
`92`	`92`	`}`
	`93`	`+ defer file.Close()`
`93`	`94`	`_, err = io.Copy(file, data)`
`94`	`95`	`if err != nil {`
`95`	`96`	`return journalError(err.Error())`