manifest-rhel-10.1: add azure-vm-utils for Azure udev rules

[aaradhak]

Add azure-vm-utils package to RHEL 10.1 manifest to replace custom Azure udev rules with upstream rules from the azure-vm-utils package. This provides proper Azure VM disk/device configuration including support for NVMe devices via azure-nvme-id.

The azure-vm-utils package is only available in RHEL 10.1 as of now which is why it is added only to manifest-rhel-10.1.yaml. This replaces the custom overlay udev rules previously maintained in overlay.d/25rhcos-azure-udev/.

Fixes: https://issues.redhat.com/browse/COS-2074
Related: openshift/os#1776

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aaradhak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @aaradhak, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines Azure VM disk and device configuration for RHEL 10.1 by integrating the official azure-vm-utils package. This update replaces a set of custom, locally maintained udev rules with upstream solutions, ensuring robust and standardized support for Azure environments, including critical NVMe device handling.

Highlights

• Package Addition: The azure-vm-utils package has been added to the manifest-rhel-10.1.yaml file. This package is specifically for RHEL 10.1 and later.
• Udev Rules Modernization: This change replaces custom Azure udev rules with upstream rules provided by the azure-vm-utils package, improving Azure VM disk/device configuration.
• NVMe Support: The new package ensures proper support for NVMe devices through azure-nvme-id, enhancing performance and compatibility on Azure.
• Custom Rules Removal: The previously maintained custom udev rules file, overlay.d/25rhcos-azure-udev/usr/lib/udev/rules.d/80-azure-disk.rules, has been removed as it is no longer needed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the azure-vm-utils package to the RHEL 10.1 manifest to use upstream Azure udev rules, and removes the old custom udev rules file. While adding the package is a good improvement for RHEL 10.1, removing the udev rules file from the repository will negatively affect other OS versions that are built from this configuration and still rely on those rules. I have provided a critical comment with a suggested alternative to address this issue.

[aaradhak]

rhcos-devel pipeline build with the azure-vm-utils pkg - https://jenkins-rhcos--devel-pipeline.apps.int.preprod-stable-spoke1-dc-iad2.itup.redhat.com/blue/organizations/jenkins/build/detail/build/44/pipeline/

[dustymabe]

This file would still be needed for rhel-9.6 IIUC.

[aaradhak]

Yes you are right, even after the code freeze in rhel-9.6, I believe this would be needed. I will add it back.

[dustymabe]

The azure-vm-utils package is only available in RHEL 10.1

This was the original expectation, but the team actually got this into RHEL 9 as well (RHEL 9.7+): https://issues.redhat.com/browse/RHEL-88789

I think my new recommendation here is that we:

1. wait until we branch rhel-9.6 so that our changes don't impact that stream
2. make this change in fedora-coreos-config to drop the existing (now obsolete) fcc overlay and also specify azure-vm-utils for el variants too.

[openshift-ci]

@aaradhak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/scos-9-build-test-qemu	0aa95d8	link	true	/test scos-9-build-test-qemu

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.